🚀 v3 Request: fiber.Ctx type of interface

[balcieren]

If fiber.Ctx will be interface , we can customize it.

Example

type CustomCtx struct {
	fiber.Ctx
}

func (c *CustomCtx) Foo() {
	println("foo")
}

func (c *CustomCtx) Bar() {
	println("bar")
}

app.Get("/", func(c CustomCtx) error {
	c.Foo()
	c.Bar()
	return c.JSON("")
})

[efectn]

Similar to:

• https://github.com/labstack/echo/blob/master/context.go#L19
• https://echo.labstack.com/guide/context/

[trim21]

I have a question about this, what stop users doing the same thing if Ctx is a struct?

package main

import (
	"fmt"

	"github.com/gofiber/fiber/v2"
)

type CustomCtx struct {
	*fiber.Ctx
}

func (cc CustomCtx) Foo() {
	fmt.Println("foo")
}

func (cc CustomCtx) Boo() {
	fmt.Println("bar")
}

func main() {
	app := fiber.New(fiber.Config{})

	app.Get("/", func(c *fiber.Ctx) error {
		cc := CustomCtx{c}

		cc.Foo()
		cc.Boo()

		return cc.JSON("")
	})
}

[efectn]

package main

import (
	"fmt"

	"github.com/gofiber/fiber/v2"
)

type CustomCtx struct {
	*fiber.Ctx
}

func (cc CustomCtx) Foo() {
	fmt.Println("foo")
}

func (cc CustomCtx) Boo() {
	fmt.Println("bar")
}

func main() {
	app := fiber.New(fiber.Config{})

	app.Get("/", func(c *fiber.Ctx) error {
		cc := CustomCtx{c}

		cc.Foo()
		cc.Boo()

		return cc.JSON("")
	})
}

Yes it works. However, interfaces give us more extendable and readability. I support using interface as Ctx type because of its.

[trim21]

It doesn't have any difference with your example, did I miss something?

Is there a more complex example?

[efectn]

It doesn't have any difference with your example, did I miss something?

Is there a more complex example?

If context is an interface, we can use type casting:

cc := c.(*CustomCtx)

But usages like return cc.SendString("") gives an segmentation error. I should find a solution for this problem

[efectn]

It doesn't have any difference with your example, did I miss something?

Is there a more complex example?

Check #1928 (comment)
i made some changes.