Avoid switch statement in particles shader to workaround shader compiler crash on Apple silicon devices #91436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
bug
topic:rendering
crash
cherrypick:4.1
|
Shouldn't there be a comment here (and on |
Sure! In practice I'm not sure it matters since we would reject any PR that just changes an if statement to a switch |
…ash on macOS devices
clayjohn
force-pushed
the
4.2-particles-crash
branch
from
ff8f44f to
b566060
Compare
akien-mga
approved these changes
May 2, 2024
|
Thanks! |
|
"We would reject any PR that contain a switch" only works as long as you know/remember what and why. A comment is a much more futureproof solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial cherrypick of #88816 for 4.2 and 4.1. This is the minimum needed to avoid the crash on Apple silicon devices (#72469)
I tested and confirmed that the issue is specifically using a switch statement where the first condition does nothing ¯\_(ツ)_/¯