Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editor may shake when showing/hiding the property tooltips popup on i3wm #98135

Closed
Rindbee opened this issue Oct 13, 2024 · 2 comments · Fixed by #98160
Closed

The editor may shake when showing/hiding the property tooltips popup on i3wm #98135

Rindbee opened this issue Oct 13, 2024 · 2 comments · Fixed by #98160

Comments

@Rindbee
Copy link
Contributor

Rindbee commented Oct 13, 2024

Tested versions

Reproducible in: v4.3.dev6.official [64520fe], v4.4.dev.custom_build [92e51fc]
Not reproducible in: v4.3.dev5.official [c9c17d6]

System information

Godot v4.3.dev6 - Linux Mint 22 (Wilma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (nvidia; 535.183.01) - Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 Threads)

Issue description

This might be an i3wm specific issue. When there are multiple tiled windows, the property tooltips popup may cause the editor to shake when it is displayed or hidden.

Peek.2024-10-13.17-29.mp4

First reproduced after #89058 was merged. CC @dalexeev

p_target->get_viewport()->add_child(tooltip);

Adding a popup to the root window when the root window is tiled seems to cause jitter, even if the popup is hidden.

Can tooltip be added as a child node of p_target?

Steps to reproduce

This might be an i3wm specific issue. i3 version 4.23 (2023-10-29)

Cannot reproduce with only one editor window open on screen. Reproducible when opening an editor window and other tiled windows on the screen:

  1. Hover the mouse over the property in the Inspector dock.
  2. Move the mouse away to hide the tooltips popup.

Minimal reproduction project (MRP)

N/A

@bikemurt
Copy link
Contributor

bikemurt commented Oct 16, 2024

This might be an i3wm specific issue.

I think this might be the case. I'm not seeing the issue on Windows (Win11/Godot 4.3.dev6).

@Rindbee
Copy link
Contributor Author

Rindbee commented Oct 16, 2024

I think this might be the case. I'm not seeing the issue on Windows (Win11/Godot 4.3.dev6).

This is caused by the actual width of the editor window being less than the lower limit of 1024. This situation is more common in tiling window managers such as i3wm and sway. I reproduced it in sway (version 1.9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants