Crash when right clicking on node with sub-resources

[nyxkn]

Godot version

v4.2.dev.custom_build [7e67b49]

System information

Godot v4.2.dev (7e67b49) - Arch Linux #1 ZEN SMP PREEMPT_DYNAMIC Thu, 21 Sep 2023 12:54:31 +0000 - Tty - GLES3 (Compatibility) - AMD Radeon R9 380 Series (tonga, LLVM 16.0.6, DRM 3.54, 6.5.4-zen2-1-zen) () - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)

Issue description

In the Scene dock, if I have a node with sub-resources, e.g. a Sprite2D node with a GradientTexture2D, when I right click on it the editor crashes. Right-clicking a few times is required to reproduce.

On the first right-click the context menu opens normally.

On the second right-click I get this error message:

ERROR: Node not found: "Sub-Resources" (relative to "/root/@EditorNode@17034/@Panel@13/@VBoxContainer@14/@HSplitContainer@17/@HSplitContainer@25/@VSplitContainer@27/@TabContainer@29/Scene/@PopupMenu@5118").
   at: get_node (scene/main/node.cpp:1630)

On the third I get a crash:

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.dev.custom_build (7e67b496ff7e35f66b88adcbdd5b252d01739cbb)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/lib/libc.so.6(+0x3e710) [0x7fad9586f710] (??:0)
[2] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x455246e) [0x55c650f6b46e] (/usr/include/c++/13.2.1/bits/atomic_base.h:505)
[3] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x2929f8d) [0x55c64f342f8d] (/home/nyxkn/apps/godot/scene/gui/popup_menu.cpp:1914 (discriminator 1))
[4] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x1a78c07) [0x55c64e491c07] (/home/nyxkn/apps/godot/editor/scene_tree_dock.cpp:2956)
[5] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x1a7bb6c) [0x55c64e494b6c] (/home/nyxkn/apps/godot/./core/variant/binder_common.h:303 (discriminator 1))
[6] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x4541fd7) [0x55c650f5afd7] (/home/nyxkn/apps/godot/core/object/object.cpp:1120)
[7] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x1b776fa) [0x55c64e5906fa] (/home/nyxkn/apps/godot/./core/variant/variant.h:301)
[8] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x1b8a903) [0x55c64e5a3903] (/home/nyxkn/apps/godot/./core/variant/binder_common.h:303 (discriminator 2))
[9] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x4541fd7) [0x55c650f5afd7] (/home/nyxkn/apps/godot/core/object/object.cpp:1120)
[10] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x2a50983) [0x55c64f469983] (/home/nyxkn/apps/godot/./core/variant/variant.h:301)
[11] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x2a75b48) [0x55c64f48eb48] (/home/nyxkn/apps/godot/scene/gui/tree.cpp:2868 (discriminator 2))
[12] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x2a74a4b) [0x55c64f48da4b] (/home/nyxkn/apps/godot/scene/gui/tree.cpp:3023)
[13] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x2a77d44) [0x55c64f490d44] (/home/nyxkn/apps/godot/./core/object/ref_counted.h:209)
[14] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x26eb940) [0x55c64f104940] (/home/nyxkn/apps/godot/scene/main/viewport.cpp:1589 (discriminator 1))
[15] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x26f50ee) [0x55c64f10e0ee] (/home/nyxkn/apps/godot/./core/object/ref_counted.h:222)
[16] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x270b3f9) [0x55c64f1243f9] (/home/nyxkn/apps/godot/./core/object/ref_counted.h:222)
[17] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x274d845) [0x55c64f166845] (/home/nyxkn/apps/godot/./core/object/ref_counted.h:209)
[18] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x59db0f) [0x55c64cfb6b0f] (/home/nyxkn/apps/godot/platform/linuxbsd/x11/display_server_x11.cpp:3777)
[19] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x4229047) [0x55c650c42047] (/usr/include/c++/13.2.1/x86_64-pc-linux-gnu/bits/gthr-default.h:749)
[20] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x422ba4d) [0x55c650c44a4d] (/home/nyxkn/apps/godot/./core/object/ref_counted.h:209)
[21] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x59f11b) [0x55c64cfb811b] (/home/nyxkn/apps/godot/./core/templates/local_vector.h:319)
[22] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x5792d0) [0x55c64cf922d0] (/home/nyxkn/apps/godot/platform/linuxbsd/os_linuxbsd.cpp:931)
[23] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x56be88) [0x55c64cf84e88] (/home/nyxkn/apps/godot/platform/linuxbsd/godot_linuxbsd.cpp:74)
[24] /usr/lib/libc.so.6(+0x27cd0) [0x7fad95858cd0] (??:0)
[25] /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7fad95858d8a] (??:0)
[26] /home/nyxkn/apps/godot/bin/godot.linuxbsd.editor.x86_64(+0x5768e5) [0x55c64cf8f8e5] (??:?)
-- END OF BACKTRACE --
================================================================

Steps to reproduce

Add a Sprite2D node, set the texture to a new GradientTexture2D (or any other). Then right-click a few times on the Sprite2D node in the Scene tab.

Just to be clear, this context menu here:

Minimal reproduction project

Nothing special here, but if it saves some time:

rightclick.zip

[YuriSizov]

@KoBeWi Seems like it's related to auto-freeing sub-popups.

[nyxkn]

FWIW, if I go back to the dev5 tag (e3e2528) the issue doesn't seem to be there.