Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home/end keys are unusable in the In-built #78189

Closed
svprdga opened this issue Jun 13, 2023 · 11 comments
Closed

Home/end keys are unusable in the In-built #78189

svprdga opened this issue Jun 13, 2023 · 11 comments

Comments

@svprdga
Copy link

svprdga commented Jun 13, 2023

Godot version

4.0.3.stable.official

System information

macOS: Vulkan API 1.2.231 - Forward Mobile - Using Vulkan Device #0: Apple - Apple M2 Pro

Issue description

The built-in editor is completely ignoring the home and end keys.

Steps to reproduce

Create a new Godot project, create a script, go to the editor and try jumping to the start or end using the home/end keys. These keys are unusable on Mac.

Minimal reproduction project

This issue can easily be reproduced in all projects created with Godot.

@AThousandShips

This comment was marked as outdated.

@AThousandShips

This comment was marked as outdated.

@AThousandShips

This comment was marked as outdated.

@AThousandShips AThousandShips closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
@svprdga svprdga changed the title In-built editor does not respect system shortcuts Home/end keys are unusable in the In-built Jun 13, 2023
@svprdga
Copy link
Author

svprdga commented Jun 13, 2023

@AThousandShips forget about the custom mappings, I have changed the issue. The built-in editor is completely ignoring the home/end keys.

In Linux these keys are working as expected, in fact, I expect all regular keys in my keyboard to work in the the built-in editor.

@AThousandShips
Copy link
Member

Can indeed not confirm on Windows, does this happen any time or at specific times such as during auto-complete?

@svprdga
Copy link
Author

svprdga commented Jun 13, 2023

It happens all the time, it looks like the editor just isn't getting events from those keys.

@AThousandShips
Copy link
Member

AThousandShips commented Jun 13, 2023

Looks like it is mapped differently on mac, seemingly to:

  • CTRL-A
  • CMD/CTRL-LEFT

It seems it doesn't use ui_home but ui_text_caret_line_start for this navigation

Edit: Can indeed confirm that it is ui_text_caret_line_start/end that is used for navigation in the code editor, you can change it under Editor Settings and Shortcuts

@svprdga
Copy link
Author

svprdga commented Jun 13, 2023

Mmh yes, it had not occurred to me to try to correct it from the editor shortcuts, I have managed to make it respond as I want through this configuration:

Captura de pantalla 2023-06-13 a las 17 34 48

Anyway, I found it weird that a specific configuration would be necessary for something that should work by default...

Feel free to close this issue if you feel no action is appropriate.

@AThousandShips
Copy link
Member

AThousandShips commented Jun 13, 2023

These settings are set up specifically for mac, to follow the usual setup AFIK, does home/end do anything else, there's no automatic collision detection between actions in the editor AFIK

Was done in #43663 it seems by popular demand

At risk of repeating myself, feel free to open a proposal about generalizing this and optionally having other keys mapped by default, I believe there's some differing opinions on the key bindings but can't remember where I've seen it if at all

@bruvzg
Copy link
Member

bruvzg commented Jun 13, 2023

Pretty much none of the Mac apps use Home/End. +Left/Right and Ctrl+A/E are standard shortcuts on macOS from moving to beginning/end of the line. But it does not seem to be used for anything, so probably can be added as an alternative.

@svprdga
Copy link
Author

svprdga commented Jun 13, 2023

Pretty much none of the Mac apps use Home/End. ⌘+Left/Right and Ctrl+A/E are standard shortcuts on macOS from moving to beginning/end of the line. But it does not seem to be used for anything, so probably can be added as an alternative.

I understand, thanks for the clarification.

I am going to close this issue then since in my case I have customized keymaps on Mac to imitate the style of Windows/Linux. If "traditional" Mac users use the keys that you mention, I understand that a change would not be necessary, but in my particular case, modify the shortcuts to customize them to my workflow.

@svprdga svprdga closed this as completed Jun 13, 2023
@AThousandShips AThousandShips closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants