Vulkan Mobile: decal cull layers do not sync to changes on visual layers of meshes.

[jcarlosrc]

Godot version

4.0 RC3

System information

Ubuntu 22.04

Issue description

If we set a cull layer to a decal, and update meshes to different layers, these changes are not updated to the decal. We need to "reset" the decal cull layer by clearing all its cull layers and assign it again in the editor for the changes to take effect. In the videos, a decal with a cull layer = 1 shows in a mesh instance at layer 3. We need to reset decal layers for the culling to work.

screen_recorder-2023-02-21_15.28.42.mp4

screen_recorder-2023-02-21_15.35.38.mp4

Steps to reproduce

Set a decal and some meshes. Change the meshes layers. This change will not show in the editor nor in the game. Now reset decal layer by empty its cull layer and then choosing a new one. Now changes are visible and decal will cull properly.

Minimal reproduction project

mobile_decal_cull_layer_bug.zip

[clayjohn]

This should be a quick fix. When the VisualInstance3D layer is set we need to flag that the mesh needs to be paired again. We do something similar with lights already:

godot/servers/rendering/renderer_scene_cull.cpp

Lines 851 to 863 in 7e79aea

	if ((1 << instance->base_type) & RS::INSTANCE_GEOMETRY_MASK && instance->base_data) {
	InstanceGeometryData *geom = static_cast<InstanceGeometryData *>(instance->base_data);
	ERR_FAIL_NULL(geom->geometry_instance);
	geom->geometry_instance->set_layer_mask(p_mask);
	if (geom->can_cast_shadows) {
	for (HashSet<RendererSceneCull::Instance *>::Iterator I = geom->lights.begin(); I != geom->lights.end(); ++I) {
	InstanceLightData *light = static_cast<InstanceLightData *>((*I)->base_data);
	light->shadow_dirty = true;
	}
	}
	}
	}

[Calinou]

Can anyone check if #80911 fixes this?