Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot 4 beta 14 regression] Tilemap layer's modulate property has no effect when Tilemap and its layer's y-sort are both enabled #72519

Closed
SouthpawGoblin opened this issue Feb 1, 2023 · 5 comments · Fixed by #77079
Assignees
Milestone

Comments

@SouthpawGoblin
Copy link

Godot version

v4.0.beta16.official [518b9e5]

System information

Windows 11, Forward+

Issue description

When a Tilemap and its layer's y-sort are both enabled, the layer's modulate property won't take effect.
image

If the layer's y-sort is disabled, the modulate property works fine.
image

And the problem extends to Tilemap's own modulate property of CanvasItem.
image
image

Steps to reproduce

  1. add a Tilemap node to the scene, enable its y-sort property
  2. add a layer to the Tilemap, draw some non-transparent tiles on the layer
  3. modify the layer's modulate property, it'll take effect on the tiles
  4. enable the layer's y-sort property, the modulate effects will vanish

Minimal reproduction project

N/A

@CarlCochet
Copy link

CarlCochet commented Feb 2, 2023

I think the bug appeared between Beta 13 and Beta 14. I have a project that works perfectly in Beta 13 and has this issue when I switch to 14+.

@therockerline
Copy link

I also have the same problem, the version is v4.0.beta14.official [28a2463]

@YuriSizov YuriSizov moved this to To investigate in Tiles, Tiles, Tiles Mar 19, 2023
@olibombardier
Copy link

I feel like I'm not familiar with the engine code to fix this issue yet, I tryed to understand how the tilemap rendering works but I'm not sure I understand. I might give it a try later.

By doing a bisect I at least found what commit caused the issue, maybe it will help somebody more familiar with the code: 10849a6d

@akien-mga akien-mga changed the title [Godot 4 beta 16] Tilemap layer's modulate property has no effect when Tilemap and its layer's y-sort are both enabled [Godot 4 beta 14 regression] Tilemap layer's modulate property has no effect when Tilemap and its layer's y-sort are both enabled Apr 20, 2023
@akien-mga akien-mga added this to the 4.1 milestone Apr 20, 2023
@WilhelmT
Copy link

I have then same issue.

The problem only appears when using y_sort. Is there a workaround?

@mhaddy
Copy link

mhaddy commented May 8, 2023

Issue still exists in 4.0.2 stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants