Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion Tool Problem #66256

Open
Tracked by #73960
feendrache opened this issue Sep 22, 2022 · 5 comments · May be fixed by #66150
Open
Tracked by #73960

Conversion Tool Problem #66256

feendrache opened this issue Sep 22, 2022 · 5 comments · May be fixed by #66150

Comments

@feendrache
Copy link

Godot version

4 Beta 1

System information

Windows 10

Issue description

I converted my 3.5 project to 4
there is a "world" folder in the res where i store some of my stuff
the conversion tool exchanged all references from world to world3d wich broke plenty of links and references

Steps to reproduce

convert a 3.5 project with a world folder in res

Minimal reproduction project

No response

@gotnospirit
Copy link
Contributor

gotnospirit commented Sep 23, 2022

This should be solved with #66150 for GDScripts.
Adding a minimal reproduction project would help to check this

@Proggle
Copy link
Contributor

Proggle commented Oct 6, 2022

This should be solved with #66150 for GDScripts. Adding a minimal reproduction project would help to check this

Here you go! This is a minimal project where the conversion mangles the resource path, so it looks for 'World3D/World3D.png' instead of 'World/World.png'

image

SampleProjectBeforeAndAfterConversion.zip

@akien-mga akien-mga added this to the 4.0 milestone Oct 6, 2022
@gotnospirit
Copy link
Contributor

I confirm that it will also solve this issue

before:

 4 4 World/World.tscn 0
    Checking file took      0.001 ms.
                Line(4), Texture -> Texture2D  -  LINE """ [ext_resource path="res://World/World.png" type="Texture" id=2] """
                Line(4), World -> World3D  -  LINE """ [ext_resource path="res://World/World.png" type="Texture" id=2] """
                Line(6), World -> World3D  -  LINE """ [node name="World" type="Node2D"] """
                Line(9), Sprite -> Sprite2D  -  LINE """ [node name="World" type="Sprite" parent="."] """
                Line(9), World -> World3D  -  LINE """ [node name="World" type="Sprite" parent="."] """

after:

 4 4 World/World.tscn 0
    Checking file took      0.001 ms.
                Line(4), Texture -> Texture2D  -  LINE """ [ext_resource path="__EXCLUDED_FROM_SCAN__" type="Texture" id=2] """
                Line(9), Sprite -> Sprite2D  -  LINE """ [node name="__EXCLUDED_FROM_SCAN__" type="Sprite" parent="__EXCLUDED_FROM_SCAN__"] """

@TomasVojta
Copy link

Same problem here:
in Godot 3.5.1:
var default_texture = preload("res://World/Interactive Objects/Button/button_temp.png")
converted in Godot 4.0 to:
var default_texture = preload("res://World3D/Interactive Objects/Button/button_temp.png")

@Warlaan
Copy link
Contributor

Warlaan commented Feb 12, 2023

I haven't tested it for file names, scripts etc., but it still happens with node names.
Nodes called "World" are still renamed to "World3D" in the tscn file.

Version: v4.0.rc1.official [8843d9a]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants