Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include option to disable !=, ==, === icons (ligatures, glyphs) in text editor #62654

Closed
TokisanGames opened this issue Jul 3, 2022 · 6 comments

Comments

@TokisanGames
Copy link
Contributor

Godot version

Godot 4 e093cfd

System information

Win 10/64 NVIDIA GeForce GTX 1060/PCIe/SSE2

Issue description

This may seem like an ungrateful nitpick, but it would be appreciated if the option to disable the conversion of
!= into this icon
image
would be great. I can't find any option to disable it in the editor settings.

This goes for any other text replacing icons.
I've also found == turns into
image
and === turns into
image
, though I don't even know if that's an operator.

While it may be nice for some users, I think it's less readable, and I can't type image
so don't want to see it in my code.

Steps to reproduce

Type != in the editor.

Minimal reproduction project

No response

@Rindbee
Copy link
Contributor

Rindbee commented Jul 3, 2022

You can avoid this by overriding interface/editor/code_font with another font.

@Calinou
Copy link
Member

Calinou commented Jul 3, 2022

This is already available as the contextual ligatures editor setting. No need to change the code font 🙂

It was already discussed in past issues as to whether code ligatures should be enabled by default. We chose to leave them enabled by default as is done in other popular code editors.

@Calinou Calinou closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2022
@TokisanGames
Copy link
Contributor Author

I see the setting, thank you. TIL what contextual ligatures means. Note there is no editor description for the option.

@TokisanGames TokisanGames changed the title Include option to disable !=, ==, === icons in text editor Include option to disable !=, ==, === icons (ligatures, glyphs) in text editor Jul 3, 2022
@Calinou
Copy link
Member

Calinou commented Jul 3, 2022

Note there is no editor description for the option.

This is pending for #48548 to be merged. It's stuck on a CI issue though.

@Poonaka
Copy link

Poonaka commented Aug 18, 2022

We should reconsider having this on by default, it's pretty confusing/annoying. I use Visual Studio, VS code and Jetbrains Rider and have never seen ligatures used before.

@Calinou
Copy link
Member

Calinou commented Aug 18, 2022

We should reconsider having this on by default, it's pretty confusing/annoying. I use Visual Studio, VS code and Jetbrains Rider and have never seen ligatures used before.

See #63865.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants