-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot crashes on every confirmation dialog box/window #58886
Comments
Can't reproduce on Mageia 9 with KDE Plasma on X11, might be Wayland specific. |
Can't reproduce on Debain 11, Xfce, X11, Nvidia, Vulkan on v4.0.alpha.custom_build [f488a84] |
@akien-mga I could have sworn that I had also tested it on Gnome under X11, but apparently not...this issue does in fact not appear under X11 for me. Must have been introduced by something that was committed after Alpha 3 release |
I could reproduce it on Mageia 9 with GNOME on X11, this and #58860 seem to be GNOME specific. |
The crash happens due to a stack overflow in EditorToaster, it's printing the same error ad lib about constructing a Callable with an empty string. Here's the error being spammed by the EditorToaster, triggering an attempt to display it again in the toaster and so on:
|
Yes, I have to correct my earlier comment after some further testing and it also happens on X11 frequently now. It did work only on my first test, it appears. |
Here's the bottom of the stacktrace:
@timothyqiu I suspect #58742. |
I will test builds before and after the commit in question and report back |
Nope, that's not the culprit. I tested a local revert and can still reproduce the bug. |
I put a breakpoint on
|
@akien-mga that was my suspicion, too. I have reverted back to 8e57e5d (one commit before the one in question) and can confirm, that the issue does not happen with this build. |
Seems like depending on the timing of window open animation, sometimes "ConfigureNotify" is received before window is mapped, and "SetInputFocus" fails. |
And stack overflow seems to be an unrelated issue, with the cleanup after |
Godot version
4.0 dev, f488a84
System information
Fedora Linux 35, Vulkan, Gnome 41 (Wayland), Radeon RX580
Issue description
Godot crashes or freezes whenever a confirmation dialog box in the editor pops up (e.g. save scene as). The content of the confirmation dialog window is black. The editor becomes unusable after that and the process must be killed. This issue is not present in Godot 4 alpha 3
This is the console output I get:
Godot Engine v4.0.alpha.custom_build.f488a841c - https://godotengine.org Vulkan API 1.2.189 - Using Vulkan Device #0: AMD - AMD RADV POLARIS10 X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 42 (X_SetInputFocus) Serial number of failed request: 6937 Current serial number in output stream: 6938 ERROR: BUG: Unreferenced static string to 0: physics_process at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: physics_process_internal at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: _update_script_names at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: GizmoLightmapGI at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: EditorRect2D at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: PrevScene at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: GuiHsplitBg at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: GuiToggleOnDisabledMirrored at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: title_button_font_size at: unref (core/string/string_name.cpp:117) ERROR: BUG: Unreferenced static string to 0: show_errors_panel at: unref (core/string/string_name.cpp:117) ERROR: Condition "!EditorSettings::get_singleton()->has_setting(p_setting)" is true. Returning: Variant() at: _EDITOR_GET (editor/editor_settings.cpp:1062) ERROR: Condition "!EditorSettings::get_singleton()->has_setting(p_setting)" is true. Returning: Variant() at: _EDITOR_GET (editor/editor_settings.cpp:1062)
Edit: This issue is probably related to #58860 where a more special case is described
Steps to reproduce
Open a new project and force a confirmation dialog window to pop up (e.g. "Save Scene as" or "Viewport Settings")
Minimal reproduction project
No response
The text was updated successfully, but these errors were encountered: