-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on project load (Noise Texture?) #58818
Comments
Another case:
|
Indeed after removing any OpenSimplexNoise resoures from my project the Godot editor finally loads the project without crashing. |
Well, maybe it wasn't the solution, because I just had the same crash again:
|
This affects other people working on the project as well. Some of us have to run Godot editor 10 times to get a good run and be able to open the project. I've just had 4 crashes in a row before finally by chance Godot loaded the project instead of crashing. |
This is likely a race condition as NoiseTexture is generated on a thread. |
I've tried to purge all noise textures from my codebase, as I don't really need them... |
I don't remember if OpenSimplexNoise is generated on a thread, but I think it is too. Either way, we might replace OpenSimplexNoise with FastNoiseLite for 4.0: #56718 |
Is there somethig I can do before that gets merged to workaround this problem? |
You could use a statically generated noise image and read its pixels instead of using OpenSimplexNoise. |
Sure, the issue now is how do I locate all the problematic places. Grepping the codebase for "noise" maybe could work? |
Yes, probably. |
This works. |
Issue persists after FastNoiseLite. |
I discussed #66845 with Zylann on Rocketchat and Zylann provided some useful insight:
|
Can you still reproduce this in 4.0.3 and 4.1-beta3 or later? |
From time to time when loading my project on macOS, I will get a string of dozens of crashes and other times it will load fine. Always from |
This seems to be at least somewhat related to #54269. In fact the original stack trace in this issue seems to be exactly the same. So I'll close the other one in favor of this one, which has more discussion. |
Just happened to me on master
I do sometimes get random crashes when opening project (I think?) and now I was using a debug build, so I managed to catch some stack trace. |
Fixed by #91630. |
Godot version
v4.0.alpha.calinou.c9d052330
System information
Arch Linux, KDE Plasma, Radeon RX580, amdgpu driver, Vulkan
Issue description
2 our of 3 times I start Godot and load my project, I get an instant crash. It's been here for a while, but with recent nightly builds it's a bit worse for me still.
Here's full terminal output from starting the Editor to loading the project and crashing:
Steps to reproduce
Clone this project (not the specific commit):
https://codeberg.org/unfa/Liblast/src/commit/4a03995213e6b97c380c07b43366a6e534100033
And open it in the editor.
me an my project team members are often running Godot over and over until it finally doesn't crash on project load.
Minimal reproduction project
No response
The text was updated successfully, but these errors were encountered: