Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collada import: bones are incorrectly positioned #56242

Open
Blackiris opened this issue Dec 25, 2021 · 3 comments
Open

Collada import: bones are incorrectly positioned #56242

Blackiris opened this issue Dec 25, 2021 · 3 comments

Comments

@Blackiris
Copy link
Contributor

Godot version

v4.0.dev.custom_build [1906b59]

System information

Archlinux, Vulkan

Issue description

I know that DAE models are obsolete and being replaced by GLTF, but for project migrating from Godot 3.0, it might be useful nonetheless to support them.

Here is a simple model with 3 bones done in Blender 3.0:
image

When exported using the Better Collada Exporter and imported using Godot 4.0, the bones are messy:
image

For comparison, here is the same model, but exported using the default Blender Collada exporter:
image

For information: using GLTF, the bones are fines after import.

Before commit 5ffed49 New and improved IK system, it works fine.
It was then partially fixed by commit [a54fe3f] collada: fix error in use of fix_transform.

Steps to reproduce

Open the project, and create a new scene inherited from the skeleton_better.dae. The Blender file is also included for testing.

Minimal reproduction project

DAE_skeleton_Test.zip

@Blackiris
Copy link
Contributor Author

Looks like it is linked to the bone rest position: changing values in the DAE file make the bone position moving (especially the last 16 numbers):

<source id="id-controller-7-bind_poses">
	<float_array id="id-controller-7-bind_poses-array" count="48">  1.0 -0.0 0.0 -0.0 -0.0 0.0 1.0 12.073701858520508 0.0 -1.0 0.0 -0.0 -0.0 0.0 -0.0 1.0    1.0 -0.0 0.0 -0.0 -0.0 0.0 1.0 0.1018838882446289 0.0 -1.0 0.0 -0.0 -0.0 0.0 -0.0 1.0    1.0 -0.0 0.0 -0.0 -0.0 0.0 1.0 -12.129661560058594 0.0 -1.0 0.0 -0.0 -0.0 0.0 -0.0 1.0  </float_array>

@fire fire changed the title Collada import: bones are incorrectly positionned Collada import: bones are incorrectly positioned Jan 4, 2022
@fire
Copy link
Member

fire commented Jan 4, 2022

Maybe related to #53765

@fire
Copy link
Member

fire commented Feb 18, 2023

We couldn't budget enough effort on collada and godotengine/godot-proposals#2130 is in limbo. Not sure what to do.

@akien-mga akien-mga modified the milestones: 4.0, 4.1, 4.x Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants