Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Manager have strange named enums RoomManager.RoomManager::PVS_MODE_DISABLED #51926

Closed
qarmin opened this issue Aug 20, 2021 · 1 comment
Closed
Assignees
Milestone

Comments

@qarmin
Copy link
Contributor

qarmin commented Aug 20, 2021

Godot version

3.4 beta 2

System information

Ubuntu 21.04 - Nvidia GTX 970, Gnome shell 3.38 X11

Issue description

RoomManager have 3 strange enums

RoomManager.RoomManager::PVS_MODE_DISABLED
RoomManager.RoomManager::PVS_MODE_FULL
RoomManager.RoomManager::PVS_MODE_PARTIAL

Cannot use them, because Godot shows GDScript error

Others enums looks in this way

SceneState.GEN_EDIT_STATE_DISABLED
SceneState.GEN_EDIT_STATE_INSTANCE
SceneState.GEN_EDIT_STATE_MAIN
SceneTree.GROUP_CALL_DEFAULT
SceneTree.GROUP_CALL_REALTIME
SceneTree.GROUP_CALL_REVERSE
SceneTree.GROUP_CALL_UNIQUE

Steps to reproduce

Above

Minimal reproduction project

No response

@lawnjelly
Copy link
Member

Ah it's probably how I've bound them doesn't work with the macro:

	BIND_ENUM_CONSTANT(RoomManager::PVS_MODE_DISABLED);
	BIND_ENUM_CONSTANT(RoomManager::PVS_MODE_PARTIAL);
	BIND_ENUM_CONSTANT(RoomManager::PVS_MODE_FULL);

And looking at the other places BIND_ENUM_CONSTANT is used, the class scope isn't used so maybe this is causing problems. Will try this out tomorrow. 👍

@qarmin qarmin closed this as completed Sep 12, 2021
@qarmin qarmin added this to the 3.4 milestone Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants