Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegible texts in audio bus editor when using a light theme #50583

Closed
timothyqiu opened this issue Jul 18, 2021 · 2 comments · Fixed by #50593
Closed

Illegible texts in audio bus editor when using a light theme #50583

timothyqiu opened this issue Jul 18, 2021 · 2 comments · Fixed by #50593

Comments

@timothyqiu
Copy link
Member

Godot version

3.3.2, 3.x(9636dea), 4.0.dev (b76dfde)

System information

macOS 11.4

Issue description

When using light themes, name of the Master audio bus is hard to read. I think it's even using the same color as the background when in focus:

name

In 3.x, no matter which theme you use, the volume preview tooltip shown when dragging the volume handle is also using a similar color as the background:

tooltip

Steps to reproduce

For the master bus name, change editor theme to Light.

Drag the volume handle in audio bus editor to see the tooltip, note that it's different from the hover tooltip.

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Jul 18, 2021

In 3.x, no matter which theme you use, the volume preview tooltip shown when dragging the volume handle is also using a similar color as the background:

This should have been fixed by #49130, which was cherry-picked to 3.x.

Did you switch from a Dark to Light theme at run-time, or did you restart the editor after changing the theme? Many editor theming bugs only occur when changing the theme at run-time.

@Calinou Calinou added the bug label Jul 18, 2021
@Calinou Calinou changed the title Illegible texts in audio bus editor Illegible texts in audio bus editor when using a light theme Jul 18, 2021
@timothyqiu
Copy link
Member Author

@Calinou The 3.x screenshots are from 9636dea which is the current latest 3.x.

The Dark theme screenshot is what you get after opening a default editor. Restarting the editor after switching the Light theme does not help, the text color still looks the same as in the screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants