Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of obsolete methods to deprecate #4398

Closed
akien-mga opened this issue Apr 22, 2016 · 4 comments
Closed

List of obsolete methods to deprecate #4398

akien-mga opened this issue Apr 22, 2016 · 4 comments

Comments

@akien-mga
Copy link
Member

We have quite a few obsolete and/or empty methods that should be deprecated, as they can be quite misleading for the users (see e.g. this question about OS.get_fullscreen_mode_list()). Especially OS seems to have a good share of obsolete methods, that when asked about @reduz says "Don't use it, it's obsolete, use instead".

So this issue is meant to list and discuss such methods, to see which ones we should deprecate (and which ones should not be deprecated but maybe improved/fixed). Once #4397 is solved, we should have a simple way to efficiently deprecate methods.

@akien-mga
Copy link
Member Author

akien-mga commented May 11, 2016

To deprecate for 2.1

  • OS.get_fullscreen_mode_list
  • OS.set_video_mode

Already deprecated for 2.1

@akien-mga akien-mga changed the title List of obsolete/empty methods to deprecate List of obsolete methods to deprecate May 11, 2016
@hurikhan
Copy link
Contributor

Just stumbled over it.

  • OS.get_borderless_window()
  • OS.set_borderless_window()

Looks like it is only implementated in OS.initialize() for windows.
Is it also deprecated?

@akien-mga
Copy link
Member Author

OS.get_borderless_window()
OS.set_borderless_window()

Nope, those were added recently, but indeed only for Windows. If those would be relevant for other platforms, we should probably open an issue about it to keep track of their implementation.

@akien-mga
Copy link
Member Author

Superseded by #5696.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants