Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iMac Retina OS.get_screen_dpi() incorrect in 3.2.3 release #42474

Closed
JayHiserote opened this issue Oct 1, 2020 · 2 comments · Fixed by #42477
Closed

iMac Retina OS.get_screen_dpi() incorrect in 3.2.3 release #42474

JayHiserote opened this issue Oct 1, 2020 · 2 comments · Fixed by #42477

Comments

@JayHiserote
Copy link

Version 3.2.3

iMac Retina 27 inch, Late 2015 (5120x2880)
MacOs Catalina 10.15.7

My application under development in Godot 3.2.1 reports an OS.get_screen_dpi() = 217
After installing 3.2.3 my application reports an OS.get_screen_dpi() = 144

Allow Hidpi is on in the project's display settings.

I believe the dpi value reported in 3.2.1 (217) is correct.

@akien-mga
Copy link
Member

CC @bruvzg

@bruvzg bruvzg self-assigned this Oct 1, 2020
@bruvzg bruvzg added this to the 4.0 milestone Oct 1, 2020
@bruvzg
Copy link
Member

bruvzg commented Oct 1, 2020

Indeed, is seems to return 144 for all displays with scale != 1 and 72 for scale == 1, I messed it up in #40084 cause 144 is correct for my display, but previous version of code seems to return completely inaccurate values as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants