Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog window title bar are visible in Windows(os) #37377

Open
Tracked by #37734
ThakeeNathees opened this issue Mar 28, 2020 · 9 comments
Open
Tracked by #37734

dialog window title bar are visible in Windows(os) #37377

ThakeeNathees opened this issue Mar 28, 2020 · 9 comments

Comments

@ThakeeNathees
Copy link
Contributor

Godot version: 307b1b3

OS/device including version: windows10

Issue description:
title bar is visible in dialog windows in Windows(os). also dragging them around makes the window lagging
windows-title-bar
windows-title-bar4
windows-title-bar3
windows-title-bar2

@Calinou
Copy link
Member

Calinou commented Mar 28, 2020

We should probably hide the minimize/maximize buttons for modal dialogs like these. This would free up some space for the window title to display.

@ThakeeNathees
Copy link
Contributor Author

IMO, the Window's title bar and the border should be hidden, and we should draw the title and a close icon.

@Calinou
Copy link
Member

Calinou commented Mar 28, 2020

@ThakeeNathees Indeed, switching to client-side decorations is a long-term plan but it'll take a fair amount of effort.

@swarnimarun
Copy link
Contributor

Why not let some of these be inside the same window? It's not like new Node Dialog needs to be a new Window....

@RandomShaper
Copy link
Member

I think that small dialogs should also be not resizable. I've always found "unprofessional" that a dialog with very little content can be resized so it looks weird, as if the UI was unpolished.

@reduz
Copy link
Member

reduz commented Jun 30, 2020

I don't think this should be classified as a bug, and its a bit difficult to infer which dialogs should be resizable and which should not. This is not something that could be done automatically in the AcceptDialog base class, but something that someone has to go and disable in every dialog that they don't think should be resizable.

@KoBeWi
Copy link
Member

KoBeWi commented Jul 10, 2022

I think the title bars are ok (and the dragging lag is gone for some time now), but we should at least make sure that whole title is displayed.
image

We should probably hide the minimize/maximize buttons for modal dialogs like these.

This can be achieved with the unresizable flag, but this makes the window unresizable (bruh).

@YuriSizov YuriSizov added this to the 4.1 milestone Feb 21, 2023
@YuriSizov YuriSizov removed this from the 4.1 milestone Jun 22, 2023
@Calinou
Copy link
Member

Calinou commented Jun 30, 2024

The issue KoBeWi mentioned is fixed in 4.2 thanks to #80409.

I agree AcceptDialogs and ConfirmationDialogs should generally not be resizable, but we should make sure we fix the issue where editor dialogs occasionally spawn with a size that's too large before making them unresizable.

Like this:

  • The first time you try to quit with unsaved changes:

image

  • The second time:

image

@KoBeWi
Copy link
Member

KoBeWi commented Jun 30, 2024

We can hide the buttons, but still keep the window resizable. Not supported right now, but it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants