Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export right icon (ricon) from Button to GDScript #29719

Closed
silkentrance opened this issue Jun 12, 2019 · 6 comments
Closed

Export right icon (ricon) from Button to GDScript #29719

silkentrance opened this issue Jun 12, 2019 · 6 comments

Comments

@silkentrance
Copy link
Contributor

The Button class features a right icon (ricon) that is used internally by the Godot editor plugin.

It would be nice for this to be a public feature so that we can implement similar functionality (collapsed/not collapsed) using GDScript as well without the need for us to reinvent the wheel here.

@volzhs
Copy link
Contributor

volzhs commented Jun 12, 2019

would you share a screenshot to specify which one of editor plugin?

@silkentrance
Copy link
Contributor Author

silkentrance commented Jun 12, 2019

Well it is mostly in the Inspector

image

The section headers are basically tool buttons that feature the ricon for presenting a collapsed/non-collapsed state.

@Chaosus Chaosus changed the title Feature: Export right icon (ricon) from Button to GDScript Export right icon (ricon) from Button to GDScript Jun 28, 2019
@jitspoe
Copy link
Contributor

jitspoe commented Jul 19, 2019

Looking at the button source, I only see one icon being drawn. Are you sure there's a right icon and not just another button/image placed there?

Related, though, I think it would be good to expose a left/right/center alignment option for the icons, like the text has: #11380

@silkentrance
Copy link
Contributor Author

@jitspoe Yes, thanks for pointing this out. I mixed that up with the lineedit control. What I meant was the collapsible section stuff implemented into the editor and that we should have such a feature in the normal gui elements as well.

@KoBeWi
Copy link
Member

KoBeWi commented May 26, 2020

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

(on a side note, the collapse/expand icon are drawn on the button by the inspector. You can already replicate this behavior with scripts)

@jitspoe
Copy link
Contributor

jitspoe commented May 28, 2020

I have a pull request here for centered and right-aligned icons: #37181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants