Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemList.unselect() should be ItemList.deselect() #28558

Closed
Jummit opened this issue May 1, 2019 · 2 comments
Closed

ItemList.unselect() should be ItemList.deselect() #28558

Jummit opened this issue May 1, 2019 · 2 comments
Labels
archived enhancement topic:core

Comments

@Jummit
Copy link
Contributor

Jummit commented May 1, 2019 •
edited
Loading

Godot version:
3.1.1

Issue description:
ItemList.unselect() is a very strange name. ItemList.deselect() is easier to find.

We have all these deselects:
image

And only this unselect:
image
@akien-mga akien-mga mentioned this issue May 1, 2019
Closed
83 tasks
@akien-mga
Copy link
Member

Good point. I've added it to the list in #16863.

@Jummit
Copy link
Contributor Author

Jummit commented May 1, 2019

Maybe even rename deselect_all to match this:
image

@madmiraal madmiraal mentioned this issue Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
archived enhancement topic:core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akien-mga @Jummit