Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to select class items in theme #21078

Closed
QbieShay opened this issue Aug 16, 2018 · 3 comments
Closed

No way to select class items in theme #21078

QbieShay opened this issue Aug 16, 2018 · 3 comments

Comments

@QbieShay
Copy link
Contributor

QbieShay commented Aug 16, 2018

Godot version: 3.1 custom build

Issue description:
Themes allow different Items for each class but there is no way to select them. For example, I have a Label with 3 different fonts and I would like to be able to select the font that fit best in that situation.

Steps to reproduce:

  1. Make a theme
  2. Make a class (Label)
  3. Make a class item (font)
  4. Make another class item (font)
  5. Try to apply one of the two fonts in the editor
@Chaosus
Copy link
Member

Chaosus commented Apr 17, 2019

Seems like #20320, but not sure whether it a duplicate or not..

@YuriSizov
Copy link
Contributor

YuriSizov commented Jun 20, 2021

If I understand correctly, Chaosus is right that this is a duplicate of #20320 and therefore of godotengine/godot-proposals#850. Both of which, I believe, are covered by this PR: #47544.

@YuriSizov
Copy link
Contributor

#47544 and #50169 make it possible to define variations of theme classes and pick them from a list in the Inspector (and set them via code too if needed).

I don't think that in the foreseeable future we will be able to pick from a list of available items on a single class, so this is the solution that we have for this problem. So I'll close this.

@akien-mga akien-mga added this to the 4.0 milestone Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants