Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineEdit caret blink method name #16116

Closed
AlexHolly opened this issue Jan 27, 2018 · 4 comments
Closed

LineEdit caret blink method name #16116

AlexHolly opened this issue Jan 27, 2018 · 4 comments

Comments

@AlexHolly
Copy link
Contributor

Godot Master

Any reason why these are called cursor and not caret in LineEdit?

caret_position

set_cursor_position(value)  -> set_caret_position(value)
get_cursor_position() -> get_caret_position()

caret_blink_speed

cursor_set_blink_speed(value) -> set_caret_blink_speed(value)
cursor_get_blink_speed() -> get_caret_blink_speed()

caret_blink

cursor_set_blink_enabled(value) -> set_caret_blink_enabled(value) 
cursor_get_blink_enabled() -> is_caret_enabled() 

append_at_cursor( String text ) -> append_at_caret( String text )

@akien-mga
Copy link
Member

CC @Paulb23. It's too late to change those for 3.0 though, so if there's a real need to rename them, we'll have to keep the deprecated method names for a while to avoid breaking API.

@AlexHolly
Copy link
Contributor Author

When are the next API changes planned? This is not a major thing. I would suggest to keep it until the next changes.

@akien-mga
Copy link
Member

4.0, or before with a proper deprecation warning over a couple releases.

@akien-mga
Copy link
Member

Closing as now tracked in #16863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants