Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project icon as favicon in HTML5 WebAssembly export #13083

Closed
nylnook opened this issue Nov 20, 2017 · 1 comment · Fixed by #22161
Closed

Project icon as favicon in HTML5 WebAssembly export #13083

nylnook opened this issue Nov 20, 2017 · 1 comment · Fixed by #22161

Comments

@nylnook
Copy link

nylnook commented Nov 20, 2017

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Firefox 57 and Chromium 62 under Archlinux 64bits, Godot compiled today 33ffdba and WebAssembly template idem

Issue description:
This can be done manually, but it would be great if Godot could export automatically the project icon as a favicon in HTML5.
I know this was partially answered in #12543:

We need ability for users to add a custom icon for their executable, not have to rely on resource hacker

Problem with this is that it seems to be only doable when exporting from Windows. Cant be done from other platforms. All libraries we tried to do this ended up corrupting the executable.

but as far as I understand this do not apply to HTML5 because it's not about writing it to an executable, but a matter of copying the .png file, renaming to favicon.png, and linking in the HTML file.

For now, the debug console in the browser is complaining about icon missing:

**ERROR**: Error opening file: res://icon.png
**ERROR**:    At: core/io/image_loader.cpp:54:load_image() - Error opening file: res://icon.png

Thanks for your answer and work !

@akien-mga akien-mga changed the title [Wishlist] Project icon as favicon in HTML5 WebAssembly export Project icon as favicon in HTML5 WebAssembly export Nov 20, 2017
@akien-mga
Copy link
Member

Sounds good to me, and shouldn't be too hard to implement. cc @eska014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants