Fix typed arrays of scripts not being decoded properly #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #699.
This is likely the same issue as what's mentioned here, which seems to stem from the fact that
decode_TypedArray
doesn't take into account all the forms that typed arrays can be encoded in.Typed arrays can conditionally encode either a
uint32_t
as the type, if the array contains a built-in type, or aString
if the array contains scripts of some kind, anddecode_TypedArray
currently only accounts for the former and not the latter.This PR fixes this issue by incorporating not only
HEADER_DATA_FIELD_TYPED_ARRAY_BUILTIN
, but alsoHEADER_DATA_FIELD_TYPED_ARRAY_CLASS_NAME
andHEADER_DATA_FIELD_TYPED_ARRAY_SCRIPT
, as found here.Similar to what's already being done, this also just discards this new script name/path.