-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lines Before "extends Node" Result in Outline Not Working #658
Comments
I can confirm this issue with some of the LimboAI scripts, such as: |
I don't think the extension has anything to do with this. I believe that the contents of the outline panel are directly provided by the LSP. |
Yeah, this is a bug in the Language Server, and the issue needs to be raised in the https://github.com/godotengine/godot repo. |
Did you look into what the Server is actually doing wrong? Looking at the traces from godotengine/godot#98164 the responses seem correct at a first glance. |
@HolonProduction I will have to look into this further. This extension doesn't control the outline, it forwards those messages directly to VSCode, so if only works sometimes then (in theory) there is a bug in either VSCode or the Language Server. |
@DaelonSuzuka it is in fact an (not very obvious) issue with the LSP, see godotengine/godot#99295. I guess it would be fine to close this issue again. |
That makes a lot of sense, thanks for investigating! |
Godot version
4.3dev6
VS Code version
1.89.1
Godot Tools VS Code extension version
2.0.0
System information
Windows 11
Issue description
The outline does not work properly when "extends Node" not in the first Line.
I've found several situation:
class_name in the first line, and extends in the second:
[work properly]
[not working]
use icon notation:
write comments when not using class_name:
[comments without class_name]
[comments with class_name]
Steps to reproduce
Simply write a piece of code.
The situations I found are above.
The text was updated successfully, but these errors were encountered: