Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some formatting breaks in lambda functions #624

Closed
rktprof opened this issue Mar 14, 2024 · 3 comments
Closed

Some formatting breaks in lambda functions #624

rktprof opened this issue Mar 14, 2024 · 3 comments
Assignees
Labels

Comments

@rktprof
Copy link

rktprof commented Mar 14, 2024

Godot version

4.2.1

VS Code version

VSCodium 1.87.1

Godot Tools VS Code extension version

2.0.0

System information

macOS 14.4

Issue description

I'm not sure if other operators misbehaves but I also remember seeing the syntax coloring breaking in a lambda but can't remember what/where that was, but when using an equals sign in a lambda:

poll_animation.on_complete(func() -> void:
	highlight.visible = false
)

becomes:

poll_animation.on_complete(func() -> void:
	highlight.visible=false
)

(it also happens when the lambda content is on the same row)

Steps to reproduce

Take the example code above and just save the file

@rktprof rktprof added the bug label Mar 14, 2024
@Calinou
Copy link
Member

Calinou commented Mar 14, 2024

It might be worth checking whether #605 fixes this. You can download the godot-tools artifact from the top-right corner on its checks page and extract the ZIP archive, then install the VSIX file contained in the ZIP.

@DaelonSuzuka
Copy link
Collaborator

I can say for sure that #605 does not fix this yet, but when it gets fixed that's where you'll be able to find it.

@DaelonSuzuka DaelonSuzuka self-assigned this Mar 14, 2024
DaelonSuzuka added a commit to DaelonSuzuka/godot-vscode-plugin that referenced this issue Nov 3, 2024
@DaelonSuzuka
Copy link
Collaborator

Pretty sure this was fixed and published, but I just added your example as a test case to make sure we don't have a regression.

DaelonSuzuka added a commit that referenced this issue Nov 18, 2024
* add new style of formatter snapshot tests
* add many new test cases
* fix several open issues( #728, #624, #657, #717, #734, likely more)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants