Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying Scene and Script Tabs to reduce UX ambiguity #7098

Closed
kubecz3k opened this issue Jun 16, 2023 · 5 comments
Closed

Unifying Scene and Script Tabs to reduce UX ambiguity #7098

kubecz3k opened this issue Jun 16, 2023 · 5 comments

Comments

@kubecz3k
Copy link

kubecz3k commented Jun 16, 2023

Describe the project you are working on

Different project across various clients

Describe the problem or limitation you are having in your project

The way scripts / scenes are presented requires from me a lot more mental capacity then it should

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I'm working with Godot since it's 1.0 release, since 2.x times I have occasional problems with understanding what I'm looking at, it's almost like editor is trying to trick me into thinking that I'm looking at something different then I'm, which confuses me.
Please take a look at this screenshot:
scene_tab_unification

Two places are indicating the context I'm working in is 'Enemy' while in reality I'm looking at 'Hero' script.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

To address this issue I would like to propose to extend/replace the functionality of "Open Dominant Script on Scene Change" with something much more comprehensive, I would like to propose mode where we are merging scene tabs with script tabs, so all the tabs are in the same place.
The way I imagine it to look from user perspective is as follows:

  1. With the option ON we are removing the side script view completely
  2. If user is [opening/switching to] scene which has main script attached to it, it works exactly the same way current "Open Dominant Script on Scene Change" option works
  3. If user is opening a script, editor should automatically detect if there is scene associated with this script (root node which has it), it could simply happen in a result of checking if in a directory with a script there is a scene with the same name (more sophisticated approach is to implement # 1935 proposal)
    • If there is such scene it's being open, and "Open Dominant Script on Scene Change" functionality will kick into play
    • If there is no such scene the editor will open a script, and present it in the top bar, the same bar that's currently reserved for scenes
    • Above also apply to all 'non node' scripts, so basically all resources
  1. Each time editor wants to open any script for any reason (ex. runtime crash) all the above should be respected

To summarize the idea in short words: the panel that's being used currently for scene tabs, in this mode should be used for scripts as well. Editor should be able to detect the link between Scenes and Scripts and open both when possible (and both of them would be represented by the same tab)

If this enhancement will not be used often, can it be worked around with a few lines of script?

This is about editor UX

Is there a reason why this should be core and not an add-on in the asset library?

This is about editor UX

@kubecz3k
Copy link
Author

kubecz3k commented Jun 16, 2023

Related to some degree:
#1935

@YuriSizov
Copy link
Contributor

YuriSizov commented Jun 16, 2023

This was already proposed in #966, #4457, and #5314. And to a degree in #4081.

We should really replace most of them with one well-written proposal...

@kubecz3k
Copy link
Author

I think none of those proposals recognized the need of unification whole context switching (not only the ui behind scripts / scenes but also scene tree).
My problem is with how context of the work is being presented, we should have one button that allows to switch context from one subject to another, not only script but also scene (and therefore scene tree)

@YuriSizov
Copy link
Contributor

Well, whatever your reason to have this is, it's still the same proposal. You could lend your voice to any of them to make it more likely that one of them is implemented, and then we could discuss the added QoL that you describe.

Besides, what you describe cannot be implemented in the current version of the editor without some heavy assumptions and needs #1935, yet another proposal, to act as a backbone and provide some context that we could utilize for auto-switching. So you could lend your voice to #1935 as well to give it more support and mention that it would make sense to implement it with auto-switching.

@kubecz3k
Copy link
Author

Well, fair enough duplicate is a duplicate, will close this one then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants