Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ground default color #6978

Open
me2beats opened this issue May 29, 2023 · 11 comments
Open

Change ground default color #6978

me2beats opened this issue May 29, 2023 · 11 comments
Labels

Comments

@me2beats
Copy link

me2beats commented May 29, 2023

Describe the project you are working on

plugins and games

Describe the problem or limitation you are having in your project

I find default color of the ground not so great as it could be

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I suggest to tweak the ground color a bit

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

This is the default color
image

This one looks better to me (#222627)
image

Or this (#262928)
image

UPD:
Or this one - closer to the default color, but still less brown (#2f2c26)
image

Or this (#2c2c2d)
image

If this enhancement will not be used often, can it be worked around with a few lines of script?

This can be worked around per project/scene - just set the ground color you like and then use that WorldEnvironment.
But the proposal is about the default look

Is there a reason why this should be core and not an add-on in the asset library?

The proposal is about the default look of the editor

@AThousandShips
Copy link
Member

AThousandShips commented May 29, 2023

Why is this better? You haven't given any reason, "looks better to me" isn't one. This is much less visually clear and much more cluttered or claustrophobic feeling to me

Also changing the default environment colours is compatibility breaking, and the preview should match the default world environment

This, the ease at which this can be worked around, and this is entirely about personal preference, I don't see this being very productive

@Miskler
Copy link

Miskler commented May 29, 2023

The default dark color is more pleasant to work with

@Zireael07
Copy link

"More pleasant to work with" still isn't an objective reason. WHY is it more pleasant? Because of more contrast with default white?

@me2beats
Copy link
Author

Well, yes, the perception of colors is subjective.
Therefore, I propose to choose a color by voting.

For me personally, this color looks more modern and more suitable for the editor's default theme.
Or maybe it's just because I don't like brown colors :)

In any case, I think it's interesting to get feedback from people.

@AThousandShips
Copy link
Member

AThousandShips commented May 29, 2023

Just making a compatibility breaking change for personal preference isn't valid, even if it's voted about, without any objective reasoning

Instead I would propose adding project settings to control the default colours, making it easier to configure this

@Zireael07
Copy link

I would propose adding project settings to control the default colours, making it easier to configure this

This please

@dalexeev
Copy link
Member

I think there is a more generic solution that solves more than just this problem: project templates. If you can create project templates (and choose one as the default template), then you can set any initial environment that is comfortable for you, even if your preferences differ from the global defaults.

As for the ground color, I have no opinion here, I'm not a 3D user. But I don't think slightly changing the default color is a major compatibility issue for a minor release (not a patch release). Of course, only if this change is supported by many users.

@me2beats
Copy link
Author

me2beats commented May 29, 2023

I think there is a more generic solution that solves more than just this problem: project templates.

Yea this would be great to have. The proposal is here btw #1481

@KoBeWi
Copy link
Member

KoBeWi commented May 29, 2023

This can be implemented in a way that doesn't break compatibility, by only modifying the preview Environment. It would only affect the editor and new environments created from preview.

@YuriSizov
Copy link
Contributor

This change was done on purpose to avoid tinting Godot worlds with distinct blue by default. Background contributes to the ambient light, and this current color combination, while perhaps not aesthetically pleasant, creates a more neutral environment. Which is more important to working with the engine than aesthetics since you see your imported models without deviations by default.

@yosoyfreeman
Copy link

Yeah, i used to to the same thing you did here, as is more intuitive cause you don't want to see "Ground" As part of your sky, but that said, there is a reason why most games include it in their sky or HDRI. As Yuri said, this will affect your global illumination and you don't want light on the bottom. (Technically, making it almost black would look even better).

You can test this same thing in blender. Load an HDRI, render. It looks as it should. If you do the same with one without ground is going to look messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants