Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off loop for audio in Import #3692

Closed
me2beats opened this issue Dec 18, 2021 · 11 comments
Closed

Turn off loop for audio in Import #3692

me2beats opened this issue Dec 18, 2021 · 11 comments

Comments

@me2beats
Copy link

Describe the project you are working on

A couple of games

Describe the problem or limitation you are having in your project

When making games I found myself turning off this button extremely often
turn it off

I keep Loop on for background music etc but the number of such files is much less

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Having loop turned off by default would solve the problem

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

solution

I believe loop should be off for all other formats too.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Currently it can't

Is there a reason why this should be core and not an add-on in the asset library?

Not sure if this can be done with a plugin.
But even if so, I still believe this should be in core not as a plugin.

@soundsbeard
Copy link

soundsbeard commented Dec 18, 2021

for games i make i have short sounds for:

  • each character's move, attack, receiving dmg, jump, dash, death
  • each skill
  • each interaction
  • each mob with its skills, etc
  • each dialogue piece
  • some ambient random sounds

all of them are not repeatable.
music on the other hand is about 3-5 tracks.
so yeah, its very annoying to disable loop for every tiny sound, loop should be disabled by default.

@Calinou
Copy link
Member

Calinou commented Dec 18, 2021

Duplicate of #3120.

@me2beats
Copy link
Author

That proposal is for moving Loop from an import option to a property in the AudioStreamPlayer nodes.
Does it include turning it off?

@Calinou
Copy link
Member

Calinou commented Dec 18, 2021

That proposal is for moving Loop from an import option to a property in the AudioStreamPlayer nodes.
Does it include turning it off?

Yes. This is a compatibility-breaking change, so the new default should be discussed at the same time 🙂

@KoBeWi
Copy link
Member

KoBeWi commented Dec 18, 2021

You can change the default from the Preset button menu.

@me2beats
Copy link
Author

me2beats commented Dec 18, 2021

You can change the default from the Preset button menu.

Isn't it per project?
That means I need to do this for each new project.
And the projects are not only games, they could be plugins or just test projects to test something.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 18, 2021

Isn't it per project?
That means I need to do this for each new project.

You don't make new projects that often, no? Also the defaults are stored in project.godot, so you can set it in a fresh project and then use that project.godot file for new projects.

And the projects are not only games, they could be plugins or just test projects to test something.

I don't think this is relevant for such projects.

@me2beats
Copy link
Author

You don't make new projects that often, no?

As for me, usually I create 3 new projects a day :)
many of them are test projects tho..

Also the defaults are stored in project.godot, so you can set it in a fresh project and then use that project.godot file for new projects.

I don't think this would be handy because there could be other settings that I don't want to change for the project.
So just replacing project.godot file won't be flexible solution I guess.
Having global default presets for audio and and other importable files would partially (and maybe mostly) solve the problem imo.
Something like this one
#3483

I don't think this is relevant for such projects.

I don't get why this can't be relevant. A test project or a project to test a plugin can use audio.

@me2beats
Copy link
Author

My point is that for me the ideal solution would be if loop was off by default.
And that's not only my case (we had a short discussion about this in our local discord server).

I prefer straightforward solutions, not workarounds that's why I created this proposal.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 18, 2021

I don't think this would be handy because there could be other settings that I don't want to change for the project.

No, I mean, create an empty project, change only the audio setting. Then you have empty project with just the default changed, so if you copy it, you get a new project with the default you want.
project.godot.txt
The only problem with this solution is less convenience - you need to copy this file manually to every new project.

I don't get why this can't be relevant. A test project or a project to test a plugin can use audio.

It can, but maybe it can use wavs or looping doesn't matter. I just can't imagine why would you need e.g. 10 random non-game projects that must use non-looping MP3s.

@me2beats
Copy link
Author

me2beats commented Dec 18, 2021

If the project already exists and has a lot of data, setting loop off manually in project.godot may be not so easy.
I think setting it from the editor would be even easier (set it off once then save the preset)
But I still don't get why I need to do this or anything else if the option could simply be turned off by default (in case most of Godot users find it fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants