Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CanvasItem's update() to _update() for consistency #3567

Closed
SilencedPerson opened this issue Nov 18, 2021 · 3 comments
Closed

Change CanvasItem's update() to _update() for consistency #3567

SilencedPerson opened this issue Nov 18, 2021 · 3 comments

Comments

@SilencedPerson
Copy link

Describe the project you are working on

a game

Describe the problem or limitation you are having in your project

i want to name function update but that requires me to overwrite the drawing update method

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I will now be able to define custom update() function

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

the name is changed to _update() to be consistent with the rest of the method names across the engine.

If this enhancement will not be used often, can it be worked around with a few lines of script?

gdscript is core.

Is there a reason why this should be core and not an add-on in the asset library?

it cannot be done with a add-on

@Zireael07
Copy link

Why close?

@KoBeWi
Copy link
Member

KoBeWi commented Nov 18, 2021

Something similar was suggested here: godotengine/godot#54161 (comment)
Leading underscore is reserved for virtual methods, so it couldn't be renamed to _update() anyways.

@Calinou Calinou changed the title change update() to _update() for consitency Change CanvasItem's update() to _update() for consistency Nov 18, 2021
@SilencedPerson
Copy link
Author

Why close?

sorry for late reply, it was for the reason KoBeWi mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants