Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the preview environment's directional light shadow maximum distance for sharper shadows #3274

Open
jcostello opened this issue Sep 10, 2021 · 2 comments · May be fixed by godotengine/godot#49736

Comments

@jcostello
Copy link

Describe the project you are working on

General 3D environments.

Describe the problem or limitation you are having in your project

Current default directional light shadow distance is set to 200 which is a lot and blurs a lot the shadows. 50 is a better default to have sharper shadows. Also adding a directional light manually, it has 100 as distance.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

It will improve shadow sharpness by default

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Read above

If this enhancement will not be used often, can it be worked around with a few lines of script?

No

Is there a reason why this should be core and not an add-on in the asset library?

No

@Calinou
Copy link
Member

Calinou commented Sep 10, 2021

I have a pull request for this: godotengine/godot#49736
I find 50 too short (except with BakedLightmap + shadowmasking), but 100 is reasonable.

However, no matter the shadow distance we choose as the default, it will never be an ideal fit out of the box for a given scene.

@Calinou Calinou added this to the 4.0 milestone Sep 10, 2021
@Calinou Calinou changed the title Change default environment directional light shadow distance to 50. Decrease the preview environment's directional light shadow maximum distance for sharper shadows Sep 10, 2021
@jcostello
Copy link
Author

True, 100 will be a good middle point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants