Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for FSR (AMD's Fidelity Fx) #2818

Closed
nonunknown opened this issue Jun 3, 2021 · 2 comments
Closed

Provide support for FSR (AMD's Fidelity Fx) #2818

nonunknown opened this issue Jun 3, 2021 · 2 comments

Comments

@nonunknown
Copy link

Describe the project you are working on

Testing Godot 4 features

Describe the feature / enhancement and how it helps to overcome the problem or limitation

With the comming for the long waited and beloved Godot 4 developers will get great powers (which comes with responsability ofc), Better graphics, bigger worlds, and so on... This will ofc require a lot of resources from a computer, to overcome this problem AAA studios provides support for DLSS which unfortunately is only supported on NVIDIA GPUS, and its implementation is closed source (I Think?).
But on July 1st, AMD has showed to us its own implementation The best part? Its Open Source and MIT. Maybe you're thinking: -"Ok, but this is just AMD's implementation, which means AMD GPUs only!", No it isnt, its GPU agnostic as you can see on the video above at 3:10.

image

For more information about AMD's Fidelity FX:
https://gpuopen.com/effects/

Github Repo:
https://github.com/GPUOpen-Effects

If this enhancement will not be used often, can it be worked around with a few lines of script?

This will be strictly necessary for HIGH-END projects.

Is there a reason why this should be core and not an add-on in the asset library?

as far as I know, this could be added as a new core module.

@YuriSizov
Copy link
Contributor

YuriSizov commented Jun 3, 2021

Duplicate of #2809.

No it isnt, its GPU agnostic as you can see on the video above at 3:10.

Actually, AMD later claimed that they only made a proof-of-concept of it working on NVidia's GPUs and NVidia needs to implement it on its side for it to work in games that will support FSR.

@nonunknown nonunknown changed the title Provide support for DLSS (AMD's Fidelity Fx) Provide support for FSR (AMD's Fidelity Fx) Jun 3, 2021
@phantomdesvin
Copy link

Duplicate of #2809.

No it isnt, its GPU agnostic as you can see on the video above at 3:10.

Actually, AMD later claimed that they only made a proof-of-concept of it working on NVidia's GPUs and NVidia needs to implement it on its side for it to work in games that will support FSR.

True, but remember what happened with Freesync. Nvidia wanted to do it's own expensive thing (G-sync) for a while and then they worked on supporting Freesync on their cards too. Not exactly the same thing but it could happen again, and a nice reason for it to happen would be Godot and others adopting FSR.
If FSR works well, I think that it would be very good for Godot and it's ecosystem, as it could allow a lot of laptops to play games that wouldn't be playable otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants