Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Dracula theme as a preset theme option #2392

Closed
likeich opened this issue Mar 3, 2021 · 2 comments
Closed

Add the Dracula theme as a preset theme option #2392

likeich opened this issue Mar 3, 2021 · 2 comments

Comments

@likeich
Copy link

likeich commented Mar 3, 2021

Describe the project you are working on

The Godot editor and personal Godot games.

Describe the problem or limitation you are having in your project

The default and current preset themes do not look very good and adding a new (good-looking) preset option for Godot 4.0 would make it feel fresh. (Preview below)

Screenshot from 2021-03-01 17-17-39

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Adding the Dracula Theme (MIT License) as a preset option for both the Godot Editor Theme and Text Editor Theme.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I've already implemented it in my own branch, I figured I would propose it here before issuing a pull request to see if the main contributors would be interested in it and to get feedback. My branch can be found here: godotengine/godot@master...likeich:dracula_theme
The above screenshot is from this branch.

If this enhancement will not be used often, can it be worked around with a few lines of script?

There is already a Dracula Theme for Godot that can be downloaded and installed using the terminal/command line, but this takes time that most users would not spend looking for a theme. (https://draculatheme.com/godot)

Is there a reason why this should be core and not an add-on in the asset library?

An add-on won't suffice because it requires changing multiple settings in the editor, to my knowledge this can't be done through the asset library and I don't think any other themes are there either. The editor already includes the Solarized Theme which is also MIT-Licensed, Dracula is another extremely popular theme that looks great with Godot.

@Calinou
Copy link
Member

Calinou commented Mar 3, 2021

As far as I know, there are no plans to include additional editor themes or syntax themes – it's impossible to please everyone with the default selection. Instead, we refer to the community to provide those themes. See godot-syntax-themes which is an official repository offering many themes. It accepts pull requests, so feel free to send in your own themes as well.

Also, usability-wise, the Dracula theme makes it really difficult to see which text belongs to what panel due to the faint borders. This actually harms accessibility, and I wouldn't welcome this as part of the default theme selection.

PS: The default editor theme will likely be redesigned for 4.0.

to my knowledge this can't be done through the asset library and I don't think any other themes are there either.

Syntax themes could be offered on the asset library once global plugins are implemented. Right now, it doesn't make sense as all plugins are scoped to a project.

@Calinou Calinou changed the title Add the Dracula Theme as a Preset Theme Option Add the Dracula theme as a preset theme option Mar 3, 2021
@likeich
Copy link
Author

likeich commented Mar 4, 2021

Gotcha, I was not aware of that repo of themes. In terms of the faint borders, I actually prefer that, I think it makes for a much cleaner look once you already know where the different panels are. Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants