Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theme editor #1791

Closed
Shadowblitz16 opened this issue Nov 7, 2020 · 4 comments
Closed

Improve theme editor #1791

Shadowblitz16 opened this issue Nov 7, 2020 · 4 comments

Comments

@Shadowblitz16
Copy link

Describe the project you are working on:
Zorin OS GTK Theme for Godot

Describe the problem or limitation you are having in your project:
Its very hard to go through all the controls and try to find out what does what

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
I suggest adding all the controls to this panel (even sub controls)
image

Then I suggest instead of this massive list
image
It would show something like this for the control you have selected...
image

Each control would have these properties and icons would in a icon group for press hover, focus, normal, and disabled

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
See above

If this enhancement will not be used often, can it be worked around with a few lines of script?:
This might be able to be worked around but why?
This systems is better and makes theme editing mush easier

Is there a reason why this should be core and not an add-on in the asset library?:
It a improvement over the existing one

@lentsius-bark
Copy link

I have worked with themes in Godot a fair bit and I do remember it took me a long while at times to find the right one to tweak an import. Having the option of the bottom panel theme viewer that would, for instance, allow you to choose which components to add to the theme and also let you click the one you want to edit would indeed be amazing.
One idea that popped into my mind whilst reading this proposal would be that the bottom theme panel having two tabs, one for your current theme and another for the list of all available themeable components, using the second tab for activating them within your theme resource and the first tab for seeing what your theme looks like.

@EricEzaM
Copy link

Could be merged with #1438

@barbaros83
Copy link

this proposal sounds very good, i would like to add 1 more thing, and that is a global override for all the theme settings, that way, you could set your standard theme 1 time, and edit those corner cases where you would want something diffrent

@YuriSizov
Copy link
Contributor

YuriSizov commented Mar 17, 2021

a global override for all the theme settings, that way, you could set your standard theme 1 time, and edit those corner cases where you would want something diffrent

That's already possible, is it not? You add your main theme to the topmost control, and it propagates through the whole branch of controls, and you can override individual controls with either sub-themes or by setting individual properties.

You can also set a custom default theme directly in the Project Settings:

image


I'll close this proposal, as the gist of it is already described in a more all-encompassing proposal here #1438 (comment).

That said, I'm currently working on major improvements to the Theme Editor and will probably open a new proposal to replace them all soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants