Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant search results are broken #3565

Closed
YuriSizov opened this issue May 19, 2020 · 2 comments
Closed

Instant search results are broken #3565

YuriSizov opened this issue May 19, 2020 · 2 comments
Labels

Comments

@YuriSizov
Copy link
Contributor

Your Godot version:
Any.

Issue description:
Instant search popup started to generate broken search results today. It appends .html extension twice, making links invalid.

This is probably related to readthedocs/readthedocs.org#7070 and readthedocs/readthedocs-sphinx-search#50.

I guess something RTD related must be updated? Also, we probably shouldn't depend on master tip in case of sphinx-search despite their recommendation to do so.

URL to the documentation page:
Example of a link: https://docs.godotengine.org/en/stable/classes/class_editorsettings.html.html

@YuriSizov YuriSizov added the bug label May 19, 2020
@akien-mga
Copy link
Member

It seems to work fine on latest, I think a rebuild of stable and 3.2 will fix it.

@YuriSizov
Copy link
Contributor Author

Search seems to be working fine now on stable and 3.2, and #3567 addresses the second part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants