Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array is tested in two places #93

Open
dustdfg opened this issue Oct 14, 2024 · 3 comments
Open

Array is tested in two places #93

dustdfg opened this issue Oct 14, 2024 · 3 comments

Comments

@dustdfg
Copy link

dustdfg commented Oct 14, 2024

I am not sure but it seems that these two files should be one file

https://github.com/godotengine/godot-benchmarks/blob/main/benchmarks/core/array.gd
https://github.com/godotengine/godot-benchmarks/blob/main/benchmarks/gdscript/array.gd

@Calinou
Copy link
Member

Calinou commented Oct 26, 2024

The exact use cases are a bit different, but now that we created a category for each, we should probably leave things as-is. This way, the metrics can still be compared over time on the results website.

@dustdfg
Copy link
Author

dustdfg commented Oct 27, 2024

What about if I eventually want to create similar benchmarks but for dictionary? Place them in one place? Split in two files?

@Calinou
Copy link
Member

Calinou commented Oct 28, 2024

What about if I eventually want to create similar benchmarks but for dictionary? Place them in one place? Split in two files?

I would place those in one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants