Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule support? #252

Closed
rakkarage opened this issue Mar 29, 2022 · 1 comment · Fixed by #253
Closed

Submodule support? #252

rakkarage opened this issue Mar 29, 2022 · 1 comment · Fixed by #253

Comments

@rakkarage
Copy link

rakkarage commented Mar 29, 2022

Will it ever be possible to add projects with submodules?

It seems like it is possible to create a complete release using actions or command line. Or like itch let us upload our own zip with an api?

https://stackoverflow.com/questions/14783127/git-archive-export-with-submodules-git-archive-all-recursive

git archive -o release.zip HEAD
git submodule --quiet foreach 'cd $toplevel; zip -ru release.zip $sm_path'

idk... thanks.

@Calinou
Copy link
Member

Calinou commented Mar 29, 2022

See also godotengine/godot-proposals#554.

Git submodules suffer from many usability issues and are not included in automatically generated ZIP archives, so they will probably never be supported by GitHub unless you manually create GitHub releases (which is too cumbersome for most users to do).

It is possible for moderators on the asset library to use custom download URLs (so you can point to GitHub Releases), but this is not available for regular users yet. Since asset submissions and edits require approval, I guess it's fine to allow anyone to use custom download URLs.

Edit: Pull request opened: #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants