Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/suppress clippy lints on nightly #822

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Fix/suppress clippy lints on nightly #822

merged 1 commit into from
Nov 27, 2021

Conversation

chitoyuu
Copy link
Contributor

  • Modified LocalCell<T> so the destructor is not called on a different thread. Allowed clippy::non_send_fields_in_send_ty otherwise.
  • Removed mentions of if_then_panic which is no longer a thing (https://github.com/rust-lang/rust-clippy/pull/7810).
  • A few other minor fixes.

@chitoyuu
Fix/suppress clippy lints on nightly
5d8f52c 
- Modified `LocalCell<T>` so the destructor is not called on a different
  thread. Allowed `clippy::non_send_fields_in_send_ty` otherwise.
- Removed mentions of `if_then_panic` which is no longer a thing.
- A few other minor fixes.
@Bromeon
Copy link
Member

Bromeon commented Nov 27, 2021

Thank you!

if_then_panic was renamed to manual_assert, should we not use that instead? Or are all the occurrences resolved now?

bors try

bors bot added a commit that referenced this pull request Nov 27, 2021
@bors
Try #822:
077fa2b
@Bromeon Bromeon added the quality-of-life No new functionality, but improves ergonomics/internals label Nov 27, 2021
@Bromeon Bromeon added this to the v0.10.0 milestone Nov 27, 2021
@bors
Copy link
Contributor

bors bot commented Nov 27, 2021

try

Build succeeded:

@Bromeon
Copy link
Member

Bromeon commented Nov 27, 2021

All seems green now, including nightly and MSRV.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 27, 2021

Build succeeded:

@bors bors bot merged commit 5b8b36e into godot-rust:master Nov 27, 2021
@chitoyuu
Copy link
Contributor Author

@Bromeon Sorry for the late reply. It's moved to pedantic which I don't think we check yet. Going through all pedantic lints would take some further effort.

@chitoyuu chitoyuu deleted the chore/clippy branch November 30, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chitoyuu @Bromeon