Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quaternion - Vector3 Multiplication operator #893

Closed
theKidOfArcrania opened this issue Sep 13, 2024 · 3 comments · Fixed by #894
Closed

Quaternion - Vector3 Multiplication operator #893

theKidOfArcrania opened this issue Sep 13, 2024 · 3 comments · Fixed by #894
Labels
c: core Core components feature Adds functionality to the library good first issue Good for newcomers

Comments

@theKidOfArcrania
Copy link
Contributor

the * operator for quaternion * vector3 is missing
@Bromeon
Copy link
Member

Bromeon commented Sep 13, 2024

Thanks for reporting! Would you have time to submit a pull request? 🙂

@Bromeon Bromeon added feature Adds functionality to the library good first issue Good for newcomers c: core Core components labels Sep 13, 2024
@theKidOfArcrania theKidOfArcrania mentioned this issue Sep 13, 2024
Merged
@theKidOfArcrania
Copy link
Contributor Author

Yeah submitted. Would it be considered the best practice to just use glam's libraries when possible?

@Bromeon
Copy link
Member

Bromeon commented Sep 13, 2024

Thanks a lot! 👍

Yes I think that's fine, especially for more complex operations. We can always change it in the future 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: core Core components feature Adds functionality to the library good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Mul operator for Quaternion + Vector3. theKidOfArcrania/gdext
2 participants
@Bromeon @theKidOfArcrania