Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons-symbol-defs.hbs is missing GitHub icon #176

Open
cmilanf opened this issue Jan 30, 2022 · 2 comments
Open

icons-symbol-defs.hbs is missing GitHub icon #176

cmilanf opened this issue Jan 30, 2022 · 2 comments

Comments

@cmilanf
Copy link
Contributor

cmilanf commented Jan 30, 2022

Tittle is quite self-explanatory, GitHub icon is missing from https://github.com/godofredoninja/Mapache/blob/master/partials/icons/icons-symbol-defs.hbs

It can be remediated by adding the following at Settings -> Code Injection -> Site Footer:

<svg aria-hidden="true" style="position: absolute; width: 0; height: 0; overflow: hidden;" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <defs>
        <!-- GitHub -->
        <symbol id="icon-github" viewBox="0 0 32 32">
		<title>github</title>
		<path d="M22.32 32h-8.48c0 0 0-2.56 0-4.32-5.76 1.28-7.52-3.2-7.52-3.2-1.12-2.080-2.080-3.2-2.080-3.2-2.080-1.28 0-1.12 0-1.12 2.080 0 3.2 2.080 3.2 2.080 1.92 3.2 5.28 2.72 6.4 2.080 0-1.12 0.48-2.72 1.12-3.2-4.64-0.32-8.64-3.040-8.64-8.32s1.12-6.4 2.24-7.52c-0.32-0.48-1.12-2.4 0-5.28 0 0 2.080 0 4.16 3.2 1.12-1.12 4.32-1.12 5.28-1.12 1.12 0 4.32 0 5.28 1.12 2.080-3.2 4.16-3.2 4.16-3.2 1.12 2.88 0.32 4.8 0 5.28 1.28 1.12 2.4 2.24 2.4 7.52s-3.84 8-8.48 8.48c0.64 0.48 1.12 2.4 1.12 3.2l-0.16 7.52z"></path>
	</symbol>
    </defs>
</svg>
@roniemartinez
Copy link

roniemartinez commented Feb 13, 2022

@cmilanf your solution helped but it seems off.

image

I used this as reference and it seems more consistent now.

<svg xmlns="http://www.w3.org/2000/svg" class="icon" viewBox="0 0 512 512"><path d="M256 32C132.3 32 32 134.9 32 261.7c0 101.5 64.2 187.5 153.2 217.9a17.56 17.56 0 0 0 3.8.4c8.3 0 11.5-6.1 11.5-11.4 0-5.5-.2-19.9-.3-39.1a102.4 102.4 0 0 1-22.6 2.7c-43.1 0-52.9-33.5-52.9-33.5-10.2-26.5-24.9-33.6-24.9-33.6-19.5-13.7-.1-14.1 1.4-14.1h.1c22.5 2 34.3 23.8 34.3 23.8 11.2 19.6 26.2 25.1 39.6 25.1a63 63 0 0 0 25.6-6c2-14.8 7.8-24.9 14.2-30.7-49.7-5.8-102-25.5-102-113.5 0-25.1 8.7-45.6 23-61.6-2.3-5.8-10-29.2 2.2-60.8a18.64 18.64 0 0 1 5-.5c8.1 0 26.4 3.1 56.6 24.1a208.21 208.21 0 0 1 112.2 0c30.2-21 48.5-24.1 56.6-24.1a18.64 18.64 0 0 1 5 .5c12.2 31.6 4.5 55 2.2 60.8 14.3 16.1 23 36.6 23 61.6 0 88.2-52.4 107.6-102.3 113.3 8 7.1 15.2 21.1 15.2 42.5 0 30.7-.3 55.5-.3 63 0 5.4 3.1 11.5 11.4 11.5a19.35 19.35 0 0 0 4-.4C415.9 449.2 480 363.1 480 261.7 480 134.9 379.7 32 256 32z"/></svg>

image

<svg aria-hidden="true" style="position: absolute; width: 0; height: 0; overflow: hidden;" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <defs>
        <!-- GitHub -->
        <symbol id="icon-github" viewBox="0 0 32 32">
		<title>github</title>
		<svg xmlns="http://www.w3.org/2000/svg" class="icon" viewBox="0 0 512 512"><path d="M256 32C132.3 32 32 134.9 32 261.7c0 101.5 64.2 187.5 153.2 217.9a17.56 17.56 0 0 0 3.8.4c8.3 0 11.5-6.1 11.5-11.4 0-5.5-.2-19.9-.3-39.1a102.4 102.4 0 0 1-22.6 2.7c-43.1 0-52.9-33.5-52.9-33.5-10.2-26.5-24.9-33.6-24.9-33.6-19.5-13.7-.1-14.1 1.4-14.1h.1c22.5 2 34.3 23.8 34.3 23.8 11.2 19.6 26.2 25.1 39.6 25.1a63 63 0 0 0 25.6-6c2-14.8 7.8-24.9 14.2-30.7-49.7-5.8-102-25.5-102-113.5 0-25.1 8.7-45.6 23-61.6-2.3-5.8-10-29.2 2.2-60.8a18.64 18.64 0 0 1 5-.5c8.1 0 26.4 3.1 56.6 24.1a208.21 208.21 0 0 1 112.2 0c30.2-21 48.5-24.1 56.6-24.1a18.64 18.64 0 0 1 5 .5c12.2 31.6 4.5 55 2.2 60.8 14.3 16.1 23 36.6 23 61.6 0 88.2-52.4 107.6-102.3 113.3 8 7.1 15.2 21.1 15.2 42.5 0 30.7-.3 55.5-.3 63 0 5.4 3.1 11.5 11.4 11.5a19.35 19.35 0 0 0 4-.4C415.9 449.2 480 363.1 480 261.7 480 134.9 379.7 32 256 32z"/></svg>
    </symbol>
    </defs>
</svg>

@cmilanf
Copy link
Contributor Author

cmilanf commented Feb 27, 2022

You are right, that one suits better the theme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants