Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor usage of resource name strings #85

Closed
silasbw opened this issue Feb 25, 2017 · 1 comment
Closed

Refactor usage of resource name strings #85

silasbw opened this issue Feb 25, 2017 · 1 comment

Comments

@silasbw
Copy link
Contributor

silasbw commented Feb 25, 2017

The current code copy pastas resource names in several places (e.g., common.js and namespace.js). Keeping them in a single place (e.g., defining an enum in common.js) will make them less painful to update.
@silasbw silasbw mentioned this issue Feb 25, 2017
Merged
@silasbw
Copy link
Contributor Author

silasbw commented Mar 17, 2018

The copy-pasta is fixed. I'm not sure it's worth more investment here.

@silasbw silasbw closed this as completed Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silasbw