Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA-1 Weak Authentication Algorithm vulnerability in dependency "request" #691

Open
aqan213 opened this issue Jan 15, 2021 · 5 comments
Open

Comments

@aqan213
Copy link

aqan213 commented Jan 15, 2021

Our customer reported a vulnerability in bluemix-autoscaling-agent caused by "request" package.
The vulnerability reports that

"The request package is vulnerable to Weak Authentication Algorithm. The function function in oauth.js uses SHA-1 for authentication which is no longer considered cryptographically secure." 

Here is the hierarchy of the "request" module tracking back to appmetrics

"request" --> kubernetes-client" -->"ibmapm-restclient" --> "ibmapm-embed" --> "appmetrics" --> bluemix-autoscaling-agent

According to request/request#2640 it looks like all versions of request are vulnerable and the request package is depreciated.
Can you please take a look? thanks,

@aqan213
Copy link
Author

aqan213 commented Jan 20, 2021

Hi, Can anyone help to check this issue? thanks,

@aqan213
Copy link
Author

aqan213 commented Feb 2, 2021

The customer is supposed to fix it in Feb. Is it possible to address this issue asap or can you please give us a date when you plan to do it? thanks,

@pinkyjpainadath
Copy link

Hi, We are also facing the same issue. is there a fix expected for this any time soon

@donacarr
Copy link

Hi ... any chance to replace "request" with something else not vulnerable?

@godber
Copy link
Contributor

godber commented Apr 28, 2021

There is already an issue here for request being deprecated.

#614

It would probably make sense to close this issue in preference to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants