Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated signin page breaks sign in #66

Open
dsloanather opened this issue Aug 21, 2023 · 1 comment
Open

Updated signin page breaks sign in #66

dsloanather opened this issue Aug 21, 2023 · 1 comment

Comments

@dsloanather
Copy link

The UI changed and soup needs to be updated with the correct elements

  File "/opt/homebrew/bin/aws-okta-processor", line 8, in <module>
    sys.exit(main())
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/cli.py", line 37, in main
    command.run()
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/commands/authenticate.py", line 104, in run
    credentials = self.authenticate()
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/commands/authenticate.py", line 98, in authenticate
    credentials = saml_fetcher.fetch_credentials()
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/core/fetcher.py", line 39, in fetch_credentials
    credentials = super(SAMLFetcher, self).fetch_credentials()
  File "/opt/homebrew/lib/python3.10/site-packages/botocore/credentials.py", line 657, in fetch_credentials
    return self._get_cached_credentials()
  File "/opt/homebrew/lib/python3.10/site-packages/botocore/credentials.py", line 667, in _get_cached_credentials
    response = self._get_credentials()
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/core/fetcher.py", line 136, in _get_credentials
    aws_roles, saml_assertion, _application_url, user, _organization = self._get_app_roles()
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/core/fetcher.py", line 106, in _get_app_roles
    aws_roles = saml.get_aws_roles(
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/core/saml.py", line 68, in get_aws_roles
    account_roles = get_account_roles(
  File "/opt/homebrew/lib/python3.10/site-packages/aws_okta_processor/core/saml.py", line 107, in get_account_roles
    accounts = soup.find('fieldset').find_all(
AttributeError: 'NoneType' object has no attribute 'find_all'```
@dcousineau-godaddy
Copy link

Hey @dsloanather we've noticed this as well. It appears to be an AWS issue (the AWS service health page at the time of this comment shows a [RESOLVED] Increased SAML Error Rates issue that appears to be the root cause. We're still looking into making some changes as we think this was possibly A/B testing a new UI we need to account for. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants