Bids 2567/stats page for validators without index (#2625)

* (BIDS-2567) Improve error handling and remove out-commented code

* (BIDS-2567) Improve and unify error logs in validator.go

* (BIDS-2567) Hide stats button for deposited/pending validators

* (BIDS-2567) Add period to most "could not find" pages

* (BIDS-2567) Add period to tx not found page

* (BIDS-2567) Remove line about mempool from validtor not found page

* (BIDS-2567) Implement requested changes from code review

templates/404notfound.html

@@ -10,7 +10,7 @@
       <div class="container">
         <div style="padding-top: 2rem;" class="row justify-content-between align-items-center">
           <div class="col-md-6 mb-5">
-            <h2 style="font-size:1.8rem;">Sorry, the page you are looking for could not be found</h2>
+            <h2 style="font-size:1.8rem;">Sorry, the page you are looking for could not be found.</h2>
           </div>
           <div class="col-md-5 p-3">
             {{ template "relax_svg" }}

templates/dashboardnotfound.html

@@ -3,7 +3,7 @@
 {{ define "content" }}
   {{ with .Data }}
     <div class="container mt-2">
-      <h1 class="mt-4 text-center">Sorry but we could not find the dashboard you are looking for</h1>
+      <h1 class="mt-4 text-center">Sorry but we could not find the dashboard you are looking for.</h1>
     </div>
   {{ end }}
 {{ end }}

templates/epochnotfound.html

@@ -21,7 +21,7 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-history mr-2"></i>Epoch not found</
       </div>
       <div class="card">
         <div class="card-body">
-          <div class="d-1">Sorry but we could not find the epoch you are looking for</div>
+          <div class="d-1">Sorry but we could not find the epoch you are looking for.</div>
         </div>
       </div>
     </div>

templates/eth1txnotfound.html

@@ -20,7 +20,7 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-history mr-2"></i>Tx not found</h1>
       </div>
       <div class="card">
         <div class="card-body">
-          <div class="d-1">Sorry but we could not find the tx you are looking for</div>
+          <div class="d-1">Sorry but we could not find the tx you are looking for.</div>
         </div>
       </div>
     </div>

templates/slotnotfound.html

@@ -21,7 +21,7 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-cube mr-2"></i>{{ if eq . "block" }
       </div>
       <div class="card">
         <div class="card-body">
-          <div class="d-1">Sorry but we could not find the {{ if eq . "block" }}block{{ else }}slot{{ end }} you are looking for</div>
+          <div class="d-1">Sorry but we could not find the {{ if eq . "block" }}block{{ else }}slot{{ end }} you are looking for.</div>
         </div>
       </div>
     </div>

templates/validator/heading.html

@@ -36,11 +36,13 @@ <h1 class="h4 mb-1 mb-md-0 d-flex align-items-center">
               </button>
             </span>
           {{ end }}
-          <span class="mx-1" data-toggle="tooltip" title="View daily statistics">
-            <a class="btn btn-dark text-white btn-sm" href="/validator/{{ .Index }}/stats">
-              <i class="fas fa-table"></i>
-            </a>
-          </span>
+          {{ if (and (ne .Status "deposited") (ne .Status "deposited_invalid") (ne .Status "pending")) }}
+            <span class="mx-1" data-toggle="tooltip" title="View daily statistics">
+              <a class="btn btn-dark text-white btn-sm" href="/validator/{{ .Index }}/stats">
+                <i class="fas fa-table"></i>
+              </a>
+            </span>
+          {{ end }}
         </h1>
       </div>
       <nav aria-label="breadcrumb">

templates/validator/validatornotfound.html

@@ -22,7 +22,6 @@ <h1 class="h4 mb-1 mb-md-0"><i class="fas fa-male mr-2"></i>Validator not found<
       <div class="card">
         <div class="card-body">
           <div class="d-1">Sorry, but we could not find the validator you are looking for.</div>
-          <div class="d-1">Stay calm, depending on the gas price of the transaction, <a href="https://kb.beaconcha.in/ethereum-2.0-and-depositing-process">it may still be in the mempool.</a></div>
         </div>
       </div>
     </div>