Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/proxy: avoid erroring on logout with session_id is None #9119

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented Apr 3, 2024

Details

https://id.goauthentik.io/if/admin/#/events/log/b8be48b8-ea3d-46f0-9a10-45f0d460e972


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Apr 3, 2024
@rissson rissson requested a review from a team as a code owner April 3, 2024 17:07
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 897869f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66b35c381668af0008c6cf23

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 897869f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66b35c384dab100008b9083a

@BeryJu BeryJu force-pushed the proxy-fix-nonetype-error branch from e8fee6a to 897869f Compare August 7, 2024 11:36
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (eb1b709) to head (897869f).

Files Patch % Lines
authentik/core/signals.py 50.00% 1 Missing ⚠️
authentik/enterprise/providers/rac/signals.py 50.00% 1 Missing ⚠️
authentik/providers/oauth2/signals.py 50.00% 1 Missing ⚠️
authentik/providers/proxy/signals.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9119      +/-   ##
==========================================
+ Coverage   92.57%   92.63%   +0.05%     
==========================================
  Files         729      729              
  Lines       35600    35608       +8     
==========================================
+ Hits        32957    32985      +28     
+ Misses       2643     2623      -20     
Flag Coverage Δ
e2e 49.67% <50.00%> (+0.09%) ⬆️
integration 25.28% <0.00%> (-0.01%) ⬇️
unit 90.07% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 3401065 into main Aug 7, 2024
71 of 72 checks passed
@BeryJu BeryJu deleted the proxy-fix-nonetype-error branch August 7, 2024 12:09
Copy link
Contributor

github-actions bot commented Aug 7, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-897869fae10c4d8b2f66b2046668a09c2207ac4a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-897869fae10c4d8b2f66b2046668a09c2207ac4a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-897869fae10c4d8b2f66b2046668a09c2207ac4a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-897869fae10c4d8b2f66b2046668a09c2207ac4a-arm64

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik added a commit that referenced this pull request Aug 7, 2024
* main:
  web/admin: refactor property mappings forms (#10810)
  web: bump API Client version (#10811)
  sources/saml: Basic support for EncryptedAssertion element. (#10099)
  web: bump API Client version (#10809)
  sources: add property mappings for all oauth and saml sources (#8771)
  web: bump API Client version (#10808)
  stages/authenticator: add created, last_updated and last_used metadata (#10636)
  providers/proxy: avoid erroring on logout with session_id is None (#9119)
  core: bump google-api-python-client from 2.139.0 to 2.140.0 (#10802)
  core: bump pyyaml from 6.0.1 to 6.0.2 (#10803)
  core: bump django from 5.0.7 to 5.0.8 (#10804)
  core: bump goauthentik.io/api/v3 from 3.2024063.1 to 3.2024063.2 (#10805)
  web: bump @sentry/browser from 8.23.0 to 8.24.0 in /web in the sentry group across 1 directory (#10806)
  web: bump the wdio group across 2 directories with 2 updates (#10807)
kensternberg-authentik added a commit that referenced this pull request Aug 8, 2024
* main: (25 commits)
  website/docs: add link from Install docs to Enterprise docs (#10827)
  website/docs: new upgrade page (#10742)
  stages/authenticator: actually update last_used (#10813)
  sources/ldap: Add enabled filter for ldap_password_validate signal (#10823)
  web: bump API Client version (#10821)
  sources/plex: add property mappings (#10772)
  core: bump goauthentik.io/api/v3 from 3.2024063.2 to 3.2024063.5 (#10817)
  web: bump the wdio group across 2 directories with 4 updates (#10818)
  web: bump chromedriver from 127.0.1 to 127.0.2 in /tests/wdio (#10819)
  web: update to ESLint 9 (#10812)
  website/docs: add source property mappings, rework provider property mappings (#10652)
  web/admin: refactor property mappings forms (#10810)
  web: bump API Client version (#10811)
  sources/saml: Basic support for EncryptedAssertion element. (#10099)
  web: bump API Client version (#10809)
  sources: add property mappings for all oauth and saml sources (#8771)
  web: bump API Client version (#10808)
  stages/authenticator: add created, last_updated and last_used metadata (#10636)
  providers/proxy: avoid erroring on logout with session_id is None (#9119)
  core: bump google-api-python-client from 2.139.0 to 2.140.0 (#10802)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants