Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add None check to a device's extra_description #11904

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

gergosimonyi
Copy link
Collaborator

@gergosimonyi gergosimonyi commented Nov 4, 2024

Closes #11882


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@gergosimonyi gergosimonyi requested a review from a team as a code owner November 4, 2024 15:27
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for authentik-storybook failed.

Name Link
🔨 Latest commit 418b685
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6728e7cb0c86110008b58824

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 418b685
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6728e7cbc3f86b00084a4760

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (1a02a9c) to head (418b685).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/api/devices.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11904      +/-   ##
==========================================
- Coverage   92.62%   92.56%   -0.07%     
==========================================
  Files         760      760              
  Lines       37792    37793       +1     
==========================================
- Hits        35006    34984      -22     
- Misses       2786     2809      +23     
Flag Coverage Δ
e2e 49.13% <50.00%> (-0.10%) ⬇️
integration 24.92% <0.00%> (-0.01%) ⬇️
unit 90.14% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-418b68556524372aa00438608b626a828c009a88
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-418b68556524372aa00438608b626a828c009a88-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-418b68556524372aa00438608b626a828c009a88

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-418b68556524372aa00438608b626a828c009a88-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu
Copy link
Member

BeryJu commented Nov 4, 2024

/cherry-pick version-2024.10

@BeryJu BeryJu merged commit f128ac0 into main Nov 4, 2024
60 of 66 checks passed
@BeryJu BeryJu deleted the core/fix-device-extra-description branch November 4, 2024 17:10
BeryJu pushed a commit that referenced this pull request Nov 4, 2024
…11904) (#11906)

core: add `None` check to a device's `extra_description` (#11904)

Co-authored-by: Simonyi Gergő <[email protected]>
kensternberg-authentik added a commit that referenced this pull request Nov 12, 2024
* main:
  core: add `None` check to a device's `extra_description` (#11904)
  providers/oauth2: fix size limited index for tokens (#11879)
  web: fix missing status code on failed build (#11903)
  website: bump docusaurus-theme-openapi-docs from 4.1.0 to 4.2.0 in /website (#11897)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in de (#11891)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11884)
  translate: Updates for file web/xliff/en.xlf in tr (#11878)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in tr (#11866)
  core: bump google-api-python-client from 2.149.0 to 2.151.0 (#11885)
  core: bump selenium from 4.26.0 to 4.26.1 (#11886)
  core, web: update translations (#11896)
  website: bump docusaurus-plugin-openapi-docs from 4.1.0 to 4.2.0 in /website (#11898)
  core: bump watchdog from 5.0.3 to 6.0.0 (#11899)
  core: bump ruff from 0.7.1 to 0.7.2 (#11900)
  core: bump django-pglock from 1.6.2 to 1.7.0 (#11901)
  website/docs: fix release notes to say Federation (#11889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /api/v3/authenticators/all/
2 participants