Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: add missing id attribute for button in ak-flow-input-password #11413

Merged
merged 1 commit into from
Sep 30, 2024
Merged

web: add missing id attribute for button in ak-flow-input-password #11413

merged 1 commit into from
Sep 30, 2024

Conversation

arevindh
Copy link
Contributor

@arevindh arevindh commented Sep 17, 2024 •
edited
Loading

Add missing id attribute to button in ak-flow-input-password

Details

Flow component password eye icon was missing id attribute hence the password icon was not changing properly and aria-label also not changing when the icon is clicked, both issues will be fixed in the PR,

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 56a6134
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66e93aeae81ec0000868030f

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 56a6134
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66e93aead1ce3c0008e9b47a
😎 Deploy Preview https://deploy-preview-11413--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arevindh arevindh changed the title flow/password-component: Add missing id attribute to button in ak-flow-input-password flow/password-component: Add missing id attribute for button in ak-flow-input-password Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (6b94fec) to head (56a6134).
Report is 101 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11413      +/-   ##
==========================================
+ Coverage   92.66%   92.73%   +0.07%     
==========================================
  Files         736      736              
  Lines       36490    36490              
==========================================
+ Hits        33813    33839      +26     
+ Misses       2677     2651      -26
Flag Coverage Δ
e2e 49.25% <ø> (+0.10%) ⬆️
integration 24.97% <ø> (ø)
unit 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arevindh arevindh marked this pull request as ready for review September 17, 2024 08:42
@arevindh arevindh requested a review from a team as a code owner September 17, 2024 08:42
@arevindh arevindh changed the title flow/password-component: Add missing id attribute for button in ak-flow-input-password web: Add missing id attribute for button in ak-flow-input-password Sep 17, 2024
@arevindh arevindh changed the title web: Add missing id attribute for button in ak-flow-input-password web: add missing id attribute for button in ak-flow-input-password Sep 17, 2024
RahulVadisetty91
RahulVadisetty91 reviewed Sep 17, 2024
View reviewed changes
Copy link

@RahulVadisetty91 RahulVadisetty91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In web/src/flow/components/ak-flow-password-input.ts script Instead of using setInterval, you might consider using requestAnimationFrame or an updated method for focusing the input field. This will be more efficient and less likely to cause performance issues.

kensternberg-authentik
kensternberg-authentik approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@kensternberg-authentik kensternberg-authentik merged commit e7698d2 into goauthentik:main Sep 30, 2024
68 checks passed
kensternberg-authentik added a commit that referenced this pull request Oct 2, 2024
@kensternberg-authentik
Merge branch 'main' into web/testing/cleanup-package
b817695 
* main:
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
kensternberg-authentik added a commit that referenced this pull request Oct 3, 2024
@kensternberg-authentik
Merge branch 'main' into web/testing/cleanup-package
4a59e93 
* main:
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
kensternberg-authentik added a commit that referenced this pull request Oct 3, 2024
@kensternberg-authentik
Merge branch 'main' into web/testing/unify-component-and-e2e-tests
0c4f1ea 
* main:
  web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596)
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
kensternberg-authentik added a commit that referenced this pull request Oct 3, 2024
@kensternberg-authentik
Merge branch 'main' into web/update/small-upgrades
19822fd 
* main:
  web: unify unit and end-to-end tests (#11598)
  web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596)
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
kensternberg-authentik added a commit that referenced this pull request Oct 3, 2024
@kensternberg-authentik
Merge branch 'main' into web/element/ak-select-table
0e91519 
* main: (29 commits)
  web: small fixes for elements and forms (#11546)
  web: unify unit and end-to-end tests (#11598)
  web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596)
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
  core: bump goauthentik.io/api/v3 from 3.2024082.1 to 3.2024083.1 (#11555)
  website: bump @types/react from 18.3.9 to 18.3.10 in /website (#11556)
  core: bump watchdog from 5.0.2 to 5.0.3 (#11557)
  core: bump uvicorn from 0.30.6 to 0.31.0 (#11558)
  ...
kensternberg-authentik added a commit that referenced this pull request Oct 4, 2024
@kensternberg-authentik
Merge branch 'main' into web/cf/remember-me
21ef645 
* main: (682 commits)
  web: small fixes for elements and forms (#11546)
  web: unify unit and end-to-end tests (#11598)
  web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596)
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
  core: bump goauthentik.io/api/v3 from 3.2024082.1 to 3.2024083.1 (#11555)
  website: bump @types/react from 18.3.9 to 18.3.10 in /website (#11556)
  core: bump watchdog from 5.0.2 to 5.0.3 (#11557)
  core: bump uvicorn from 0.30.6 to 0.31.0 (#11558)
  ...
kensternberg-authentik added a commit that referenced this pull request Oct 7, 2024
@kensternberg-authentik
Merge branch 'main' into web/policy-wizard-3
c139e82 
* main: (33 commits)
  web: provide simple tables for API-less displays (#11028)
  core: bump goauthentik/fips-python from 3.12.6-slim-bookworm-fips-full to 3.12.7-slim-bookworm-fips-full (#11607)
  core: bump twilio from 9.3.2 to 9.3.3 (#11608)
  core: bump msgraph-sdk from 1.8.0 to 1.9.0 (#11609)
  web: small fixes for elements and forms (#11546)
  web: unify unit and end-to-end tests (#11598)
  web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596)
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
  ...
kensternberg-authentik added a commit that referenced this pull request Nov 1, 2024
@kensternberg-authentik
Merge branch 'main' into web/cleanup/20240516-simple-element-docs-1
32db275 
* main: (481 commits)
  web: provide simple tables for API-less displays (#11028)
  core: bump goauthentik/fips-python from 3.12.6-slim-bookworm-fips-full to 3.12.7-slim-bookworm-fips-full (#11607)
  core: bump twilio from 9.3.2 to 9.3.3 (#11608)
  core: bump msgraph-sdk from 1.8.0 to 1.9.0 (#11609)
  web: small fixes for elements and forms (#11546)
  web: unify unit and end-to-end tests (#11598)
  web: audit and update package.json and associated test harness, with upgrade to WebdriverIO 9 (#11596)
  web: bump @spotlightjs/spotlight from 2.4.1 to 2.4.2 in /web in the sentry group across 1 directory (#11581)
  core: bump sentry-sdk from 2.14.0 to 2.15.0 (#11589)
  web: bump the rollup group across 2 directories with 4 updates (#11590)
  web: bump chromedriver from 129.0.1 to 129.0.2 in /tests/wdio (#11591)
  web: bump globals from 15.9.0 to 15.10.0 in /web (#11592)
  core, web: update translations (#11575)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11578)
  core: bump goauthentik.io/api/v3 from 3.2024083.1 to 3.2024083.2 (#11580)
  web: bump the eslint group across 2 directories with 4 updates (#11582)
  web: bump API Client version (#11574)
  stages/identification: dynamically find login challenges (#11571)
  web: add missing id attribute for button in ak-flow-input-password (#11413)
  internal: restore /ping behaviour for embedded outpost (#11568)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RahulVadisetty91 RahulVadisetty91 RahulVadisetty91 left review comments

@kensternberg-authentik kensternberg-authentik kensternberg-authentik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arevindh @RahulVadisetty91 @kensternberg-authentik