Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac: generate blueprint schema permissions from defined models not DB #10962

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 18, 2024

Details

This fixes the issue that when working on new features and running make gen the Blueprint schema will inherit new permissions that might not even exist in the current working dir anymore but still exist in the database.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner August 18, 2024 22:18
Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 6c81a88
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66c27350017fe900085ba176

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 6c81a88
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66c27350ea5cc00008d94bbd

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (341fc65) to head (6c81a88).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10962      +/-   ##
==========================================
- Coverage   92.71%   92.69%   -0.02%     
==========================================
  Files         736      736              
  Lines       36356    36360       +4     
==========================================
- Hits        33706    33705       -1     
- Misses       2650     2655       +5     
Flag Coverage Δ
e2e 49.18% <33.33%> (-0.01%) ⬇️
integration 25.05% <33.33%> (-0.01%) ⬇️
unit 90.24% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-6c81a88914e884e066243833f36e718fcd71c0e6
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-6c81a88914e884e066243833f36e718fcd71c0e6-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-6c81a88914e884e066243833f36e718fcd71c0e6

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-6c81a88914e884e066243833f36e718fcd71c0e6-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit eb5842f into main Aug 19, 2024
67 of 68 checks passed
@BeryJu BeryJu deleted the rbac/generate-schema-based-defined branch August 19, 2024 11:44
kensternberg-authentik added a commit that referenced this pull request Aug 26, 2024
* main: (36 commits)
  website/developer-docs: update index.md (#10958)
  docsmg/README.md: Fix typos (#10956)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#10978)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#10976)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#10977)
  web: bump @patternfly/elements from 3.0.2 to 4.0.0 in /web (#10989)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#10979)
  web: bump the swc group across 2 directories with 11 updates (#10988)
  web: bump typescript-eslint from 8.1.0 to 8.2.0 in /web (#10990)
  web: bump @goauthentik/api from 2024.6.3-1723645891 to 2024.6.3-1723921843 in /web/sfe (#10991)
  providers/saml: fix incorrect migration for sign_response (#10975)
  web: bump rollup from 4.20.0 to 4.21.0 in /web (#10969)
  website/docs: fix formatting on CVE-2024-23647 (#10955)
  core: bump ruff from 0.6.0 to 0.6.1 (#10964)
  rbac: generate blueprint schema permissions from defined models not DB (#10962)
  web: bump the swc group across 2 directories with 11 updates (#10967)
  core: bump goauthentik.io/api/v3 from 3.2024063.11 to 3.2024063.12 (#10963)
  web: bump the rollup group across 1 directory with 3 updates (#10966)
  web: bump esbuild from 0.23.0 to 0.23.1 in /web (#10970)
  web: bump rollup from 4.20.0 to 4.21.0 in /web/sfe (#10971)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant