Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle: only create tenant media root if needed #10616

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 24, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from rissson July 24, 2024 17:30
@BeryJu BeryJu requested a review from a team as a code owner July 24, 2024 17:30
@BeryJu
Copy link
Member Author

BeryJu commented Jul 24, 2024

/cherry-pick version-2024.6

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (8e4a2b7) to head (f3206e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10616      +/-   ##
==========================================
+ Coverage   92.51%   92.59%   +0.08%     
==========================================
  Files         718      718              
  Lines       35141    35141              
==========================================
+ Hits        32509    32538      +29     
+ Misses       2632     2603      -29     
Flag Coverage Δ
e2e 49.69% <ø> (+0.12%) ⬆️
integration 25.36% <ø> (ø)
unit 90.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit f3206e8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66a13a309d778a0008b0a316

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit f3206e8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66a13a30a227aa0008542a57

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f3206e88a4a6553545a37275ad64c2d8903b0259
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f3206e88a4a6553545a37275ad64c2d8903b0259-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f3206e88a4a6553545a37275ad64c2d8903b0259

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f3206e88a4a6553545a37275ad64c2d8903b0259-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit f0e2467 into main Jul 24, 2024
69 checks passed
@BeryJu BeryJu deleted the lifecycle/only-create-media-when-needed branch July 24, 2024 18:39
BeryJu added a commit that referenced this pull request Jul 24, 2024
… (#10617)

lifecycle: only create tenant media root if needed (#10616)

Co-authored-by: Jens L. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants