Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/flows: don't grab focus for password input on identification stage #10593

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 23, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner July 23, 2024 15:43
@BeryJu
Copy link
Member Author

BeryJu commented Jul 23, 2024

/cherry-pick version-2024.6

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 4f476b6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/669fcf92001dec0008c54808
😎 Deploy Preview https://deploy-preview-10593--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 4f476b6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/669fcf92d7716e00087572b1

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (c077cf5) to head (4f476b6).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c077cf5) and HEAD (4f476b6). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (c077cf5) HEAD (4f476b6)
e2e 16 8
integration 2 1
unit 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10593       +/-   ##
===========================================
- Coverage   92.52%   50.98%   -41.55%     
===========================================
  Files         718      716        -2     
  Lines       35125    34866      -259     
===========================================
- Hits        32501    17777    -14724     
- Misses       2624    17089    +14465     
Flag Coverage Δ
e2e 49.61% <ø> (+0.10%) ⬆️
integration 25.37% <ø> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 1df81ec into main Jul 23, 2024
62 of 64 checks passed
@BeryJu BeryJu deleted the web/flows/dont-grab-pw-focus branch July 23, 2024 15:58
Copy link
Contributor

Cherry-pick failed with Merge error 1df81eca86bf14d9a7062bed7e3bc3eb67cdc457 into temp-cherry-pick-663994-version-2024.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant