Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/sync: handle SkipObject in direct triggered tasks #10590

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 23, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner July 23, 2024 12:07
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit b33a090
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/669f9ce7428319000828e892

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit b33a090
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/669f9ce796739300088e107e

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.59%. Comparing base (c077cf5) to head (b33a090).

Files Patch % Lines
authentik/lib/sync/outgoing/tasks.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10590      +/-   ##
==========================================
+ Coverage   92.52%   92.59%   +0.06%     
==========================================
  Files         718      718              
  Lines       35125    35129       +4     
==========================================
+ Hits        32501    32529      +28     
+ Misses       2624     2600      -24     
Flag Coverage Δ
e2e 49.61% <0.00%> (+0.09%) ⬆️
integration 25.37% <0.00%> (-0.01%) ⬇️
unit 90.07% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b33a090f31e544584a6c9010c4673001b45979f5
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b33a090f31e544584a6c9010c4673001b45979f5-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b33a090f31e544584a6c9010c4673001b45979f5

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b33a090f31e544584a6c9010c4673001b45979f5-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu
Copy link
Member Author

BeryJu commented Jul 23, 2024

/cherry-pick version-2024.6

@BeryJu BeryJu merged commit 619707e into main Jul 23, 2024
67 of 68 checks passed
@BeryJu BeryJu deleted the lib/sync/handle-skip-direct branch July 23, 2024 13:38
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 23, 2024
BeryJu added a commit that referenced this pull request Jul 23, 2024
…0590) (#10591)

lib/sync: handle SkipObject in direct triggered tasks (#10590)

Signed-off-by: Jens Langhammer <[email protected]>
Co-authored-by: Jens L. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant